Avoid newlines when writing string secrets#1
Open
JohnLZeller wants to merge 1 commit intoGeoffreyBooth:masterfrom
Open
Avoid newlines when writing string secrets#1JohnLZeller wants to merge 1 commit intoGeoffreyBooth:masterfrom
JohnLZeller wants to merge 1 commit intoGeoffreyBooth:masterfrom
Conversation
| if [ $type = 'object' ] || [ $type = 'array' ]; then | ||
| echo "$value" | vault write "${path}" - | ||
| else | ||
| echo "$value" | vault write "${path}" value=- |
Owner
There was a problem hiding this comment.
Looks good. Shouldn’t we also update the line above?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for writing this fork! I was literally about to do a number of these things to get the dev container working again, but then I found yours :)
This PR fixes an issue I noticed with string secrets. They are being stored with a newline following the string, like when we store
bar, it comes back asbar\n