Skip to content

Feat/2d medial balls#1301

Merged
BotellaA merged 4 commits into
nextfrom
feat/2d_medial_balls
Jul 7, 2026
Merged

Feat/2d medial balls#1301
BotellaA merged 4 commits into
nextfrom
feat/2d_medial_balls

Conversation

@MoulardM

@MoulardM MoulardM commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@MoulardM MoulardM requested a review from BotellaA July 7, 2026 12:44
private:
struct CachedTree
{
absl::once_flag built;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove also useless includes

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 4 concern(s)
  • src/geode/model/helpers/ray_tracing.cpp:44:64: warning: [readability-identifier-naming]

    invalid case style for function 'directions_2D'

       44 |     const std::array< geode::Vector2D, NUMBER_2D_DIRECTIONS >& directions_2D()
          |                                                                ^~~~~~~~~~~~~
          |                                                                directions_2_d
  • src/geode/model/helpers/ray_tracing.cpp:62:64: warning: [readability-identifier-naming]

    invalid case style for function 'directions_3D'

       62 |     const std::array< geode::Vector3D, NUMBER_3D_DIRECTIONS >& directions_3D()
          |                                                                ^~~~~~~~~~~~~
          |                                                                directions_3_d
  • src/geode/model/helpers/ray_tracing.cpp:140:26: warning: [readability-function-cognitive-complexity]

    function 'is_point_inside_surface' has cognitive complexity of 14 (threshold 10)

      140 |         RayTracingResult is_point_inside_surface(
          |                          ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:143:13: note: +1, including nesting penalty of 0, nesting level increased to 1
      143 |             for( const auto& direction : ::directions_2D() )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:148:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      148 |                 for( const auto& line : section_.boundaries( surface ) )
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:153:21: note: +3, including nesting penalty of 2, nesting level increased to 3
      153 |                     if( !result )
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:160:21: note: +3, including nesting penalty of 2, nesting level increased to 3
      160 |                     if( on_border )
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:166:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      166 |                 if( could_determine )
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:169:34: note: +3, including nesting penalty of 2, nesting level increased to 3
      169 |                                  ? geode::RayTracingResult::POSITION::inside
          |                                  ^
  • src/geode/model/helpers/ray_tracing.cpp:248:26: warning: [readability-function-cognitive-complexity]

    function 'is_point_inside_block' has cognitive complexity of 14 (threshold 10)

      248 |         RayTracingResult is_point_inside_block(
          |                          ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:251:13: note: +1, including nesting penalty of 0, nesting level increased to 1
      251 |             for( const auto& direction : ::directions_3D() )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:256:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      256 |                 for( const auto& surface : brep_.boundaries( block ) )
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:261:21: note: +3, including nesting penalty of 2, nesting level increased to 3
      261 |                     if( !result )
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:268:21: note: +3, including nesting penalty of 2, nesting level increased to 3
      268 |                     if( on_border )
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:274:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      274 |                 if( could_determine )
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:277:34: note: +3, including nesting penalty of 2, nesting level increased to 3
      277 |                                  ? geode::RayTracingResult::POSITION::inside
          |                                  ^

Have any feedback or feature suggestions? Share it here.

@BotellaA BotellaA merged commit 293dd62 into next Jul 7, 2026
19 checks passed
@BotellaA BotellaA deleted the feat/2d_medial_balls branch July 7, 2026 14:19
@BotellaA

BotellaA commented Jul 7, 2026

Copy link
Copy Markdown
Member

🎉 This PR is included in version 17.4.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants