Skip to content

feat(2DMedialBalls): add 2D medial ball computation#1299

Closed
MoulardM wants to merge 2 commits into
nextfrom
feat/2d-medial-balls
Closed

feat(2DMedialBalls): add 2D medial ball computation#1299
MoulardM wants to merge 2 commits into
nextfrom
feat/2d-medial-balls

Conversation

@MoulardM

@MoulardM MoulardM commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@MoulardM MoulardM requested a review from BotellaA July 6, 2026 08:02
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 4 concern(s)
  • src/geode/model/helpers/ray_tracing.cpp:46:64: warning: [readability-identifier-naming]

    invalid case style for function 'directions_2D'

       46 |     const std::array< geode::Vector2D, NUMBER_2D_DIRECTIONS >& directions_2D()
          |                                                                ^~~~~~~~~~~~~
          |                                                                directions_2_d
  • src/geode/model/helpers/ray_tracing.cpp:64:64: warning: [readability-identifier-naming]

    invalid case style for function 'directions_3D'

       64 |     const std::array< geode::Vector3D, NUMBER_3D_DIRECTIONS >& directions_3D()
          |                                                                ^~~~~~~~~~~~~
          |                                                                directions_3_d
  • src/geode/model/helpers/ray_tracing.cpp:142:26: warning: [readability-function-cognitive-complexity]

    function 'is_point_inside_surface' has cognitive complexity of 14 (threshold 10)

      142 |         RayTracingResult is_point_inside_surface(
          |                          ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:145:13: note: +1, including nesting penalty of 0, nesting level increased to 1
      145 |             for( const auto& direction : ::directions_2D() )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:150:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      150 |                 for( const auto& line : section_.boundaries( surface ) )
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:155:21: note: +3, including nesting penalty of 2, nesting level increased to 3
      155 |                     if( !result )
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:162:21: note: +3, including nesting penalty of 2, nesting level increased to 3
      162 |                     if( on_border )
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:168:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      168 |                 if( could_determine )
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:171:34: note: +3, including nesting penalty of 2, nesting level increased to 3
      171 |                                  ? geode::RayTracingResult::POSITION::inside
          |                                  ^
  • src/geode/model/helpers/ray_tracing.cpp:250:26: warning: [readability-function-cognitive-complexity]

    function 'is_point_inside_block' has cognitive complexity of 14 (threshold 10)

      250 |         RayTracingResult is_point_inside_block(
          |                          ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:253:13: note: +1, including nesting penalty of 0, nesting level increased to 1
      253 |             for( const auto& direction : ::directions_3D() )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:258:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      258 |                 for( const auto& surface : brep_.boundaries( block ) )
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:263:21: note: +3, including nesting penalty of 2, nesting level increased to 3
      263 |                     if( !result )
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:270:21: note: +3, including nesting penalty of 2, nesting level increased to 3
      270 |                     if( on_border )
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:276:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      276 |                 if( could_determine )
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/model/helpers/ray_tracing.cpp:279:34: note: +3, including nesting penalty of 2, nesting level increased to 3
      279 |                                  ? geode::RayTracingResult::POSITION::inside
          |                                  ^

Have any feedback or feature suggestions? Share it here.

@MoulardM MoulardM closed this Jul 7, 2026
@MoulardM MoulardM deleted the feat/2d-medial-balls branch July 7, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants