Skip to content

fix(AABBHelpers): remove parallel loop that trigger deadlock#1297

Merged
BotellaA merged 3 commits into
nextfrom
fix/aabb-helpers-sync
Jul 1, 2026
Merged

fix(AABBHelpers): remove parallel loop that trigger deadlock#1297
BotellaA merged 3 commits into
nextfrom
fix/aabb-helpers-sync

Conversation

@BotellaA

@BotellaA BotellaA commented Jul 1, 2026

Copy link
Copy Markdown
Member

No description provided.

@BotellaA BotellaA requested review from MoulardM and panquez July 1, 2026 09:11
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 5 concern(s)
  • src/geode/mesh/helpers/aabb_solid_helpers.cpp:66:31: error: [clang-diagnostic-error]

    implicit instantiation of undefined template 'geode::CoordinateSystem<3>'

       66 |             coordinate_system_.coordinates( tetrahedron_vertices[0] );
          |                               ^
    /__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/aabb_solid_helpers.cpp:85:39: note: in instantiation of member function 'geode::AnisotropicDistanceToTetrahedron<3>::operator()' requested here
       85 |     template class opengeode_mesh_api AnisotropicDistanceToTetrahedron< 3 >;
          |                                       ^
    /__w/OpenGeode/OpenGeode/include/geode/mesh/helpers/aabb_solid_helpers.hpp:34:42: note: template is declared here
       34 |     FORWARD_DECLARATION_DIMENSION_CLASS( CoordinateSystem );
          |                                          ^
  • src/geode/mesh/helpers/aabb_solid_helpers.cpp:68:31: error: [clang-diagnostic-error]

    implicit instantiation of undefined template 'geode::CoordinateSystem<3>'

       68 |             coordinate_system_.coordinates( tetrahedron_vertices[1] );
          |                               ^
    /__w/OpenGeode/OpenGeode/include/geode/mesh/helpers/aabb_solid_helpers.hpp:34:42: note: template is declared here
       34 |     FORWARD_DECLARATION_DIMENSION_CLASS( CoordinateSystem );
          |                                          ^
  • src/geode/mesh/helpers/aabb_solid_helpers.cpp:70:31: error: [clang-diagnostic-error]

    implicit instantiation of undefined template 'geode::CoordinateSystem<3>'

       70 |             coordinate_system_.coordinates( tetrahedron_vertices[2] );
          |                               ^
    /__w/OpenGeode/OpenGeode/include/geode/mesh/helpers/aabb_solid_helpers.hpp:34:42: note: template is declared here
       34 |     FORWARD_DECLARATION_DIMENSION_CLASS( CoordinateSystem );
          |                                          ^
  • src/geode/mesh/helpers/aabb_solid_helpers.cpp:72:31: error: [clang-diagnostic-error]

    implicit instantiation of undefined template 'geode::CoordinateSystem<3>'

       72 |             coordinate_system_.coordinates( tetrahedron_vertices[3] );
          |                               ^
    /__w/OpenGeode/OpenGeode/include/geode/mesh/helpers/aabb_solid_helpers.hpp:34:42: note: template is declared here
       34 |     FORWARD_DECLARATION_DIMENSION_CLASS( CoordinateSystem );
          |                                          ^
  • src/geode/mesh/helpers/aabb_solid_helpers.cpp:76:31: error: [clang-diagnostic-error]

    implicit instantiation of undefined template 'geode::CoordinateSystem<3>'

       76 |             coordinate_system_.coordinates( query );
          |                               ^
    /__w/OpenGeode/OpenGeode/include/geode/mesh/helpers/aabb_solid_helpers.hpp:34:42: note: template is declared here
       34 |     FORWARD_DECLARATION_DIMENSION_CLASS( CoordinateSystem );
          |                                          ^

Have any feedback or feature suggestions? Share it here.

@BotellaA BotellaA merged commit 2cf432b into next Jul 1, 2026
20 checks passed
@BotellaA BotellaA deleted the fix/aabb-helpers-sync branch July 1, 2026 11:58
@BotellaA

BotellaA commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 17.3.6-rc.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants