Skip to content

feat(Json): move json library to opengeode#1266

Merged
BotellaA merged 3 commits intonextfrom
feat/csv_import
May 4, 2026
Merged

feat(Json): move json library to opengeode#1266
BotellaA merged 3 commits intonextfrom
feat/csv_import

Conversation

@BenPinet
Copy link
Copy Markdown
Member

@BenPinet BenPinet commented May 4, 2026

No description provided.

@BenPinet BenPinet requested a review from BotellaA May 4, 2026 14:10
Comment thread cmake/OpenGeodeConfig.cmake.in Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 2 concern(s)
  • include/geode/basic/input.hpp:64:11: warning: [cppcoreguidelines-special-member-functions]

    class 'Input' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator

       64 |     class Input : public IOFile
          |           ^
  • include/geode/basic/input.hpp:77:9: warning: [cppcoreguidelines-explicit-virtual-functions]

    annotate this function with 'override' or (rarely) 'final'

       77 |         ~Input()
          |         ^       
          |                  override

Have any feedback or feature suggestions? Share it here.

@BotellaA BotellaA merged commit 9a1b0e5 into next May 4, 2026
19 checks passed
@BotellaA BotellaA deleted the feat/csv_import branch May 4, 2026 16:53
@BotellaA
Copy link
Copy Markdown
Member

BotellaA commented May 4, 2026

🎉 This PR is included in version 16.6.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA
Copy link
Copy Markdown
Member

BotellaA commented May 6, 2026

🎉 This PR is included in version 16.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants