Skip to content

fix(Mesh): ensure CachedPolygons and CachedPolyhedra are not transfer… #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 1 commit into from
Mar 2, 2026
Merged

fix(Mesh): ensure CachedPolygons and CachedPolyhedra are not transfer… #1239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/geode/mesh/core/solid_mesh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,13 +428,9 @@ namespace geode
.template find_or_create_attribute< VariableAttribute,
PolyhedronVertex >( "polyhedron_around_vertex",
PolyhedronVertex{},
{ false, false, false } ) ),
polyhedra_around_vertex_( solid.vertex_attribute_manager()
.template find_or_create_attribute< VariableAttribute,
CachedPolyhedra >( POLYHEDRA_AROUND_VERTEX_NAME,
CachedPolyhedra{},
{ false, false, false } ) )
{
initialize_polyhedra_around_vertex( solid );
}

VerticesAroundVertex vertices_around_vertex(
Expand Down Expand Up @@ -663,8 +659,8 @@ namespace geode
polyhedra_around_vertex_ =
solid.vertex_attribute_manager()
.template find_or_create_attribute< VariableAttribute,
CachedPolyhedra >(
POLYHEDRA_AROUND_VERTEX_NAME, CachedPolyhedra{} );
CachedPolyhedra >( POLYHEDRA_AROUND_VERTEX_NAME,
CachedPolyhedra{}, { false, false, false } );
}

const internal::PolyhedraAroundVertexImpl&
Expand Down
14 changes: 6 additions & 8 deletions src/geode/mesh/core/surface_mesh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ namespace
OPENGEODE_ASSERT(
mesh.polygon_vertex( cur_polygon_vertex.value() ) == vertex_id,
"[SurfaceMesh::polygons_around_vertex] Wrong polygon "
"around vertex" );
"around vertex ",
vertex_id, " / ", cur_polygon_vertex->string(), " ",
mesh.polygon_vertex( cur_polygon_vertex.value() ) );
result.polygons.push_back( cur_polygon_vertex.value() );
const auto prev_vertex =
mesh.previous_polygon_vertex( cur_polygon_vertex.value() );
Expand Down Expand Up @@ -255,13 +257,9 @@ namespace geode
.template find_or_create_attribute< VariableAttribute,
PolygonVertex >( "polygon_around_vertex",
PolygonVertex{},
{ false, false, false } ) ),
polygons_around_vertex_( surface.vertex_attribute_manager()
.template find_or_create_attribute< VariableAttribute,
CachedPolygons >( POLYGONS_AROUND_VERTEX_NAME,
CachedPolygons{},
{ false, false, false } ) )
{
initialize_polygons_around_vertex( surface );
}

VerticesAroundVertex vertices_around_vertex(
Expand Down Expand Up @@ -403,8 +401,8 @@ namespace geode
polygons_around_vertex_ =
surface.vertex_attribute_manager()
.template find_or_create_attribute< VariableAttribute,
CachedPolygons >(
POLYGONS_AROUND_VERTEX_NAME, CachedPolygons{} );
CachedPolygons >( POLYGONS_AROUND_VERTEX_NAME,
CachedPolygons{}, { false, false, false } );
}

private:
Expand Down