fix(AABBTree): wrong parallelization scheme in containing_boxes(..)#1207
Merged
BotellaA merged 2 commits intoGeode-solutions:fix/aabb-para-bboxfrom Nov 6, 2025
Merged
Conversation
Contributor
Author
BotellaA
merged commit 12cc772
into
Geode-solutions:fix/aabb-para-bbox
4 of 5 checks passed
Member
|
🎉 This PR is included in version 15.30.1-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Member
|
🎉 This PR is included in version 15.30.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
AABBTree::containing_boxes(..)is always executed sequentially sincedepth_ > async_depth_is always true. Based on the rest of the AABBTree, I guess it's a bug.