Skip to content

fix(IO): enable serialization for signed/unsigned 8/16-bits attributes #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 1 commit into from
Oct 1, 2025
Merged

fix(IO): enable serialization for signed/unsigned 8/16-bits attributes #1193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions include/geode/basic/detail/bitsery_archive.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

#pragma once

#include <type_traits>

#include <geode/basic/bitsery_archive.hpp>

#include <absl/container/inlined_vector.h>
Expand Down Expand Up @@ -75,17 +77,28 @@ namespace geode
template < typename Serializer >
void register_basic_pcontext( PContext& context )
{
// Base types (skip aliases registered below...)
register_attribute_type< bool, Serializer >( context, "bool" );
register_attribute_type< signed char, Serializer >(
context, "signed_char" );
static_assert( std::is_same_v< unsigned char, local_index_t > );
register_attribute_type< short, Serializer >( context, "short" );
register_attribute_type< unsigned short, Serializer >(
context, "unsigned_short" );
register_attribute_type< int, Serializer >( context, "int" );
static_assert( std::is_same_v< unsigned int, index_t > );
register_attribute_type< float, Serializer >( context, "float" );
register_attribute_type< double, Serializer >( context, "double" );

// Other types or aliases
register_attribute_type< local_index_t, Serializer >(
context, "local_index_t" );
register_attribute_type< index_t, Serializer >(
context, "index_t" );
register_attribute_type< uuid, Serializer >( context, "uuid" );
register_attribute_type< std::string, Serializer >(
context, "std::string" );

register_attribute_type_for_all_containers< Serializer, double >(
context, "double" );
register_attribute_type_for_all_containers< Serializer, index_t >(
Expand Down
Loading