Skip to content

feat(BoundingBox): add n_volume computation #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 4 commits into from
Aug 20, 2025
Merged

feat(BoundingBox): add n_volume computation #1178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67d446a
feat(BoundingBox): add n_volume computation
francoisbonneau Aug 18, 2025
b52dbce
Apply prepare changes
francoisbonneau Aug 18, 2025
32ebfb5
pa suggestion
francoisbonneau Aug 19, 2025
4aa8ab4
Apply prepare changes
francoisbonneau Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/geode/geometry/bounding_box.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ namespace geode
[[nodiscard]] std::tuple< local_index_t, double >
largest_length() const;

[[nodiscard]] double n_volume() const;

[[nodiscard]] std::string string() const;

private:
Expand Down
12 changes: 12 additions & 0 deletions src/geode/geometry/bounding_box.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,18 @@ namespace geode
return -inner_distance;
}

template < index_t dimension >
double BoundingBox< dimension >::n_volume() const
{
double volume{ 1.0 };
const auto box_extent = diagonal();
for( const auto c : geode::LRange{ dimension } )
{
volume *= ( box_extent.value( c ) );
}
return volume;
}

template < index_t dimension >
std::string BoundingBox< dimension >::string() const
{
Expand Down