Skip to content

fix(Basic): add missing functions in SmallSet #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MelchiorSchuh merged 3 commits into from
Mar 15, 2025
Merged

fix(Basic): add missing functions in SmallSet #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df82456
fix(Basic): add missing functions in SmallSet
panquez Mar 10, 2025
16bfe43
Merge branch 'next' into feat/conversion-from-uv
panquez Mar 11, 2025
5ae1a80
Merge branch 'next' into feat/conversion-from-uv
panquez Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion include/geode/basic/small_set.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,16 +55,26 @@ namespace geode
return container_.end();
}

auto contains( const Type& element ) const
{
return absl::c_contains( container_, element );
}

auto insert( const Type& element )
{
if( absl::c_contains( container_, element ) )
if( contains( element ) )
{
return false;
}
container_.push_back( element );
return true;
}

auto erase( const Type& element )
{
return container_.erase( absl::c_find( container_, element ) );
}

auto at( index_t index ) const
{
return container_.at( index );
Expand Down
3 changes: 3 additions & 0 deletions tests/basic/test-small-set.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ void test()
OPENGEODE_EXCEPTION( !set.insert( 0 ), "[Test] Insert not allow" );
OPENGEODE_EXCEPTION( !set.insert( 1 ), "[Test] Insert not allow" );
OPENGEODE_EXCEPTION( set.size(), "[Test] Set size should be 2" );
set.erase( 0 );
OPENGEODE_EXCEPTION( set.size(), "[Test] Set size should be 1" );
OPENGEODE_EXCEPTION( set.at( 0 ) == 1, "[Test] Wrong value in set" );
}

OPENGEODE_TEST( "small-set" )