Skip to content

fix(Basic): missing include#1080

Merged
BotellaA merged 1 commit intoGeode-solutions:nextfrom
yo35:missing-include
Jan 30, 2025
Merged

fix(Basic): missing include#1080
BotellaA merged 1 commit intoGeode-solutions:nextfrom
yo35:missing-include

Conversation

@yo35
Copy link
Contributor

@yo35 yo35 commented Jan 30, 2025

No description provided.

@BotellaA BotellaA changed the base branch from master to next January 30, 2025 10:44
@yo35
Copy link
Contributor Author

yo35 commented Jan 30, 2025

This aims to fix the following error, encountered with GCC 13.3:

In file included from ...:
.../geode/include/geode/basic/types.hpp:52:71: error: return type ‘std::string’ {aka ‘class std::basic_string<char>’} is incomplete
   52 |     [[nodiscard]] inline std::string to_string( std::string_view view )
      |                                                                       ^
.../geode/include/geode/basic/types.hpp: In function ‘void geode::to_string(std::string_view)’:
.../geode/include/geode/basic/types.hpp:54:49: error: invalid use of incomplete type ‘std::string’ {aka ‘class std::basic_string<char>’}
   54 |         return static_cast< std::string >( view );
      |                                                 ^

@BotellaA BotellaA merged commit 127c954 into Geode-solutions:next Jan 30, 2025
3 of 5 checks passed
@BotellaA
Copy link
Member

🎉 This PR is included in version 15.9.9-rc.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA
Copy link
Member

BotellaA commented Feb 1, 2025

🎉 This PR is included in version 15.9.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@yo35 yo35 deleted the missing-include branch March 21, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants