Skip to content

fix(ComponentID): change componentid class to struct - #195

Open
BenPinet wants to merge 1 commit into
v18from
fix/change_ComponentID_to_struct
Open

fix(ComponentID): change componentid class to struct#195
BenPinet wants to merge 1 commit into
v18from
fix/change_ComponentID_to_struct

Conversation

@BenPinet

@BenPinet BenPinet commented Aug 13, 2026

Copy link
Copy Markdown
Member

No description provided.

@BenPinet
BenPinet requested a review from panquez August 13, 2026 15:28
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 257 concern(s)

  • include/geode/inspector/inspection/topology/internal/topology_helpers.hpp:44:1: warning: [modernize-concat-nested-namespaces]

    nested namespaces can be concatenated

       44 | namespace geode
      | ^~~~~~~~~~~~~~~
   45 | {
      | ~
   46 |     namespace internal
      |     ~~~~~~~~~~~~~~~~~~
      |     namespace geode::internal

  • include/geode/inspector/inspection/topology/internal/topology_helpers.hpp:99:37: error: [clang-diagnostic-error]

    variable has incomplete type 'ComponentMeshVertex'

       99 |                 ComponentMeshVertex component_mesh_vertex{ component_id,
      |                                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/include/geode/inspector/inspection/topology/internal/topology_helpers.hpp:39:12: note: forward declaration of 'geode::ComponentMeshVertex'
   39 |     struct ComponentMeshVertex;
      |            ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:55:30: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

       55 |         if( cmv.component_id.type
      |             ~~~~~~~~~~~~~~~~~^~~~
      |                                  ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:67:44: note: possible target for call
   67 |         [[nodiscard]] const ComponentType& type() const&
      |                                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:72:39: note: possible target for call
   72 |         [[nodiscard]] ComponentType&& type() &&
      |                                       ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:59:46: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

       59 |                 model.line( cmv.component_id.id ).mesh().point( cmv.vertex ) );
      |                             ~~~~~~~~~~~~~~~~~^~
      |                                                ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:61:9: warning: [llvm-else-after-return]

    do not use 'else' after 'return'

       61 |         else if( cmv.component_id.type
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   62 |                  == geode::Surface< Model::dim >::component_type_static() )
      |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   63 |         {
      |         ~
   64 |             return point.inexact_equal( model.surface( cmv.component_id.id )
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   65 |                     .mesh()
      |                     ~~~~~~~
   66 |                     .point( cmv.vertex ) );
      |                     ~~~~~~~~~~~~~~~~~~~~~~~
   67 |         }
      |         ~

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:61:35: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

       61 |         else if( cmv.component_id.type
      |                  ~~~~~~~~~~~~~~~~~^~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:67:44: note: possible target for call
   67 |         [[nodiscard]] const ComponentType& type() const&
      |                                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:72:39: note: possible target for call
   72 |         [[nodiscard]] ComponentType&& type() &&
      |                                       ^
note: this fix will not be applied because it overlaps with another fix

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:64:73: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

       64 |             return point.inexact_equal( model.surface( cmv.component_id.id )
      |                                                        ~~~~~~~~~~~~~~~~~^~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^
note: this fix will not be applied because it overlaps with another fix

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:69:44: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

       69 |             model.corner( cmv.component_id.id ).mesh().point( cmv.vertex ) );
      |                           ~~~~~~~~~~~~~~~~~^~
      |                                              ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:84:30: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

       84 |         if( cmv.component_id.type == geode::Block3D::component_type_static() )
      |             ~~~~~~~~~~~~~~~~~^~~~
      |                                  ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:67:44: note: possible target for call
   67 |         [[nodiscard]] const ComponentType& type() const&
      |                                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:72:39: note: possible target for call
   72 |         [[nodiscard]] ComponentType&& type() &&
      |                                       ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:87:47: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

       87 |                 model.block( cmv.component_id.id ).mesh().point( cmv.vertex ) );
      |                              ~~~~~~~~~~~~~~~~~^~
      |                                                 ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:100:52: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      100 |             if( !model.component( cmv.component_id.id ).is_active() )
      |                                   ~~~~~~~~~~~~~~~~~^~
      |                                                      ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:116:30: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      116 |         if( cmv.component_id.type
      |             ~~~~~~~~~~~~~~~~~^~~~
      |                                  ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:67:44: note: possible target for call
   67 |         [[nodiscard]] const ComponentType& type() const&
      |                                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:72:39: note: possible target for call
   72 |         [[nodiscard]] ComponentType&& type() &&
      |                                       ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:119:49: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      119 |             return model.line( cmv.component_id.id ).mesh().point( cmv.vertex );
      |                                ~~~~~~~~~~~~~~~~~^~
      |                                                   ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:121:30: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      121 |         if( cmv.component_id.type
      |             ~~~~~~~~~~~~~~~~~^~~~
      |                                  ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:67:44: note: possible target for call
   67 |         [[nodiscard]] const ComponentType& type() const&
      |                                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:72:39: note: possible target for call
   72 |         [[nodiscard]] ComponentType&& type() &&
      |                                       ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:124:52: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      124 |             return model.surface( cmv.component_id.id )
      |                                   ~~~~~~~~~~~~~~~~~^~
      |                                                      ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:128:47: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      128 |         return model.corner( cmv.component_id.id ).mesh().point( cmv.vertex );
      |                              ~~~~~~~~~~~~~~~~~^~
      |                                                 ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:137:52: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      137 |             if( !model.component( cmv.component_id.id ).is_active() )
      |                                   ~~~~~~~~~~~~~~~~~^~
      |                                                      ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:152:52: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      152 |             if( !model.component( cmv.component_id.id ).is_active() )
      |                                   ~~~~~~~~~~~~~~~~~^~
      |                                                      ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:156:34: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      156 |             if( cmv.component_id.type
      |                 ~~~~~~~~~~~~~~~~~^~~~
      |                                      ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:67:44: note: possible target for call
   67 |         [[nodiscard]] const ComponentType& type() const&
      |                                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:72:39: note: possible target for call
   72 |         [[nodiscard]] ComponentType&& type() &&
      |                                       ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:159:54: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      159 |                 return model.block( cmv.component_id.id )
      |                                     ~~~~~~~~~~~~~~~~~^~
      |                                                        ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:192:9: warning: [google-explicit-constructor]

    single-argument constructors must be marked explicit to avoid unintentional implicit conversions

      192 |         Impl( const Model& model )
      |         ^
      |         explicit

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:218:9: warning: [modernize-use-nodiscard]

    function 'model_has_unique_vertices_linked_to_different_points' should be marked [[nodiscard]]

      218 |         bool model_has_unique_vertices_linked_to_different_points() const
      |         ^
      |         [[nodiscard]]

  • src/geode/inspector/inspection/criterion/colocation/unique_vertices_colocation.cpp:239:9: warning: [modernize-use-nodiscard]

    function 'model_has_colocated_unique_vertices' should be marked [[nodiscard]]

      239 |         bool model_has_colocated_unique_vertices() const
      |         ^
      |         [[nodiscard]]

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:85:13: warning: [bugprone-easily-swappable-parameters]

    2 adjacent parameters of 'BRepLineSurfacesIntersection' of similar type ('const geode::uuid &') are easily swapped by mistake

       85 |             const geode::uuid& surface_id,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   86 |             const geode::uuid& line_id )
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:85:32: note: the first parameter in the range is 'surface_id'
   85 |             const geode::uuid& surface_id,
      |                                ^~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:86:32: note: the last parameter in the range is 'line_id'
   86 |             const geode::uuid& line_id )
      |                                ^~~~~~~

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:167:9: warning: [google-explicit-constructor]

    single-argument constructors must be marked explicit to avoid unintentional implicit conversions

      167 |         ModelIntersectionBase( const Model& model ) : model_( model ) {}
      |         ^
      |         explicit

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:210:13: warning: [bugprone-easily-swappable-parameters]

    2 adjacent parameters of 'polygons_intersect' of similar type ('geode::index_t') are easily swapped by mistake

      210 |             geode::index_t p1_id, geode::index_t p2_id ) const
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:210:28: note: the first parameter in the range is 'p1_id'
  210 |             geode::index_t p1_id, geode::index_t p2_id ) const
      |                            ^~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:210:50: note: the last parameter in the range is 'p2_id'
  210 |             geode::index_t p1_id, geode::index_t p2_id ) const
      |                                                  ^~~~~

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:252:17: warning: [bugprone-easily-swappable-parameters]

    2 adjacent parameters of 'triangles_common_vertices' of similar type ('const geode::PolygonVertices &') are easily swapped by mistake

      252 |                 const geode::PolygonVertices& t1_vertices,
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  253 |                 const geode::PolygonVertices& t2_vertices ) const
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:252:47: note: the first parameter in the range is 't1_vertices'
  252 |                 const geode::PolygonVertices& t1_vertices,
      |                                               ^~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:253:47: note: the last parameter in the range is 't2_vertices'
  253 |                 const geode::PolygonVertices& t2_vertices ) const
      |                                               ^~~~~~~~~~~

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:428:58: warning: [readability-function-cognitive-complexity]

    function 'triangles_intersect' has cognitive complexity of 28 (threshold 10)

      428 |         ModelSurfacesIntersectionBase< geode::Section >::triangles_intersect(
      |                                                          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:434:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  434 |         if( common_vertices.size() == 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:442:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  442 |             if( geode::segment_segment_intersection_detection< 2 >(
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:446:17: note: +1
  446 |                 || geode::segment_segment_intersection_detection< 2 >(
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:458:20: note: +1
  458 |                    || geode::point_triangle_position( t2_third_pt, triangle1 )
      |                    ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:461:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  461 |         for( const auto t1_edge_v : geode::LRange{ 3 } )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:465:44: note: +2, including nesting penalty of 1, nesting level increased to 2
  465 |                 t1_vertices[t1_edge_v == 2 ? 0 : t1_edge_v + 1]
      |                                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:469:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  469 |             for( const auto t2_edge_v : geode::LRange{ 3 } )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:473:48: note: +3, including nesting penalty of 2, nesting level increased to 3
  473 |                     t2_vertices[t2_edge_v == 2 ? 0 : t2_edge_v + 1]
      |                                                ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:479:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  479 |                 if( edge_edge_inter.first == geode::POSITION::outside
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:480:21: note: +1
  480 |                     || edge_edge_inter.first == geode::POSITION::parallel )
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:484:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  484 |                 if( common_vertices.size() != 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:492:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  492 |                 if( t1_edge_inter_pt_id == geode::NO_LID
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:493:21: note: +1
  493 |                     || t2_edge_inter_pt_id == geode::NO_LID )
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:497:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  497 |                 if( edge1_vertices[t1_edge_inter_pt_id] != common_vertices[0][0]
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:498:21: note: +1
  498 |                     || edge2_vertices[t2_edge_inter_pt_id]
      |                     ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:508:24: warning: [readability-function-cognitive-complexity]

    function 'triangle_intersects_other' has cognitive complexity of 22 (threshold 10)

      508 |     [[nodiscard]] bool triangle_intersects_other(
      |                        ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:516:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  516 |         for( const auto v_id : geode::LRange{ 3 } )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:518:42: note: +2, including nesting penalty of 1, nesting level increased to 2
  518 |             const auto v2_id = v_id == 2 ? 0 : v_id + 1;
      |                                          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:522:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  522 |             if( intersection.first != geode::POSITION::outside )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:524:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  524 |                 if( common_vertices.size() != 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:532:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  532 |                 if( edge_inter_pt_id == geode::NO_LID
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:533:21: note: +1
  533 |                     || t2_inter_pt_id == geode::NO_LID )
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:537:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  537 |                 if( t1_vertices[edge_inter_pt_id == 0 ? v_id : v2_id]
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:539:21: note: +1
  539 |                     || t2_vertices[t2_inter_pt_id]
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:537:55: note: +3, including nesting penalty of 2, nesting level increased to 3
  537 |                 if( t1_vertices[edge_inter_pt_id == 0 ? v_id : v2_id]
      |                                                       ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:538:71: note: +3, including nesting penalty of 2, nesting level increased to 3
  538 |                         != common_vertices[0][t2_vertex_position == 0 ? 1 : 0]
      |                                                                       ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:508:24: warning: [readability-function-size]

    function 'triangle_intersects_other' exceeds recommended size/complexity thresholds

      508 |     [[nodiscard]] bool triangle_intersects_other(
      |                        ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:508:24: note: 6 parameters (threshold 4)

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:577:19: warning: [readability-suspicious-call-argument]

    1st argument 'triangle2' (passed to 'triangle1') looks like it might be swapped with the 2nd, 'triangle1' (passed to 'triangle2')

      577 |                || triangle_intersects_other( triangle2, triangle1, t2_vertices,
      |                   ^                          ~~~~~~~~~  ~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:508:24: note: in the call to 'triangle_intersects_other', declared here
  508 |     [[nodiscard]] bool triangle_intersects_other(
      |                        ^
  509 |         const geode::Triangle3D& triangle1,
      |                                  ~~~~~~~~~
  510 |         const geode::Triangle3D& triangle2,
      |                                  ~~~~~~~~~

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:577:19: warning: [readability-suspicious-call-argument]

    3rd argument 't2_vertices' (passed to 't1_vertices') looks like it might be swapped with the 4th, 't1_vertices' (passed to 't2_vertices')

      577 |                || triangle_intersects_other( triangle2, triangle1, t2_vertices,
      |                   ^                                                ~~~~~~~~~~~
  578 |                    t1_vertices, common_vertices, 0 );
      |                    ~~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:508:24: note: in the call to 'triangle_intersects_other', declared here
  508 |     [[nodiscard]] bool triangle_intersects_other(
      |                        ^
  509 |         const geode::Triangle3D& triangle1,
  510 |         const geode::Triangle3D& triangle2,
  511 |         const geode::PolygonVertices& t1_vertices,
      |                                       ~~~~~~~~~~~
  512 |         const geode::PolygonVertices& t2_vertices,
      |                                       ~~~~~~~~~~~

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:613:9: warning: [modernize-use-nodiscard]

    function 'lines_intersect' should be marked [[nodiscard]]

      613 |         bool lines_intersect( geode::index_t p1_id, geode::index_t p2_id ) const
      |         ^
      |         [[nodiscard]]

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:652:9: warning: [google-explicit-constructor]

    single-argument constructors must be marked explicit to avoid unintentional implicit conversions

      652 |         Impl( const Model& model )
      |         ^
      |         explicit

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:675:69: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      675 |                     model_.surface( polygon_pair.first.component_id.id );
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                                       ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:1034:9: note: in instantiation of member function 'geode::ModelMeshesIntersections<geode::Section>::Impl::add_intersecting_surfaces_elements' requested here
 1034 |         ModelMeshesIntersections< Section >;
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:677:70: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      677 |                     model_.surface( polygon_pair.second.component_id.id );
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                                        ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:681:63: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      681 |                         " (", polygon_pair.first.component_id.id.string(),
      |                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                                 ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:684:64: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      684 |                         " (", polygon_pair.second.component_id.id.string(),
      |                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                                  ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:699:63: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      699 |                     model_.line( edge_pair.first.component_id.id );
      |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                                 ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:1034:9: note: in instantiation of member function 'geode::ModelMeshesIntersections<geode::Section>::Impl::add_intersecting_lines_elements' requested here
 1034 |         ModelMeshesIntersections< Section >;
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:701:64: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      701 |                     model_.line( edge_pair.second.component_id.id );
      |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                                  ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:705:54: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      705 |                         edge_pair.first.component_id.id.string(), ") and ",
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                        ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:707:55: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      707 |                         edge_pair.second.component_id.id.string(),
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                         ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:722:69: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      722 |                     model_.surface( polygon_pair.first.component_id.id );
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                                       ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:1034:9: note: in instantiation of member function 'geode::ModelMeshesIntersections<geode::Section>::Impl::add_surface_auto_intersecting_elements' requested here
 1034 |         ModelMeshesIntersections< Section >;
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:726:57: error: [clang-diagnostic-error]

    reference to non-static member function must be called; did you mean to call it with no arguments?

      726 |                         polygon_pair.first.component_id.id.string(),
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                           ()
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:57:35: note: possible target for call
   57 |         [[nodiscard]] const uuid& id() const&
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:62:30: note: possible target for call
   62 |         [[nodiscard]] uuid&& id() &&
      |                              ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:768:13: warning: [readability-function-cognitive-complexity]

    function 'intersecting_polygons' has cognitive complexity of 12 (threshold 10)

      768 |             intersecting_polygons() const
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:771:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  771 |             for( const auto& surface : model_.active_surfaces() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:773:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  773 |                 if( surface.mesh().nb_polygons() == 0 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:785:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  785 |             for( const auto& surface : model_.active_surfaces() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:787:51: note: nesting level increased to 2
  787 |                 tasks.emplace_back( async::spawn( [this, &surface] {
      |                                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:797:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  797 |                     for( const auto& [polygon1, polygon2] :
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:810:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  810 |             for( const auto& components : surfaces_overlap.component_pairs )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:812:51: note: nesting level increased to 2
  812 |                 tasks.emplace_back( async::spawn( [this, &components] {
      |                                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:828:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  828 |                     for( const auto& [polygon1, polygon2] :
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:838:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  838 |             for( auto& task : async::when_all( tasks ).get() )
      |             ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:848:13: warning: [readability-function-cognitive-complexity]

    function 'intersecting_lines' has cognitive complexity of 12 (threshold 10)

      848 |             intersecting_lines() const
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:853:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  853 |             for( const auto& line : model_.active_lines() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:855:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  855 |                 if( line.mesh().nb_edges() == 0 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:865:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  865 |             for( const auto& line : model_.active_lines() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:867:51: note: nesting level increased to 2
  867 |                 tasks.emplace_back( async::spawn( [this, &line] {
      |                                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:877:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  877 |                     for( const auto& [edge1, edge2] :
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:890:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  890 |             for( const auto& components : lines_overlap.component_pairs )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:892:51: note: nesting level increased to 2
  892 |                 tasks.emplace_back( async::spawn( [this, &components] {
      |                                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:908:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  908 |                     for( const auto& [edge1, edge2] :
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:918:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  918 |             for( auto& task : async::when_all( tasks ).get() )
      |             ^

  • src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:928:13: warning: [readability-function-cognitive-complexity]

    function 'intersecting_lines_surfaces' has cognitive complexity of 15 (threshold 10)

      928 |             intersecting_lines_surfaces( const BRep& brep ) const
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:933:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  933 |             for( const auto& surface : brep.active_surfaces() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:935:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  935 |                 if( surface.mesh().nb_polygons() == 0 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:943:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  943 |             for( const auto& line : brep.active_lines() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:945:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  945 |                 if( line.mesh().nb_edges() == 0 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:953:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  953 |             for( const auto& surface : brep.active_surfaces() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:958:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  958 |                 for( const auto& line : brep.active_lines() )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:960:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  960 |                     if( brep.nb_embedding_blocks( line ) == 0 )
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/intersections/model_intersections.cpp:971:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  971 |                     for( const auto& element_pair :
      |                     ^

  • src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:119:10: warning: [readability-function-cognitive-complexity]

    function 'create_graph' has cognitive complexity of 16 (threshold 10)

      119 |     void create_graph( const geode::BRep& brep,
      |          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:127:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  127 |         for( const auto& line : brep.lines() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:132:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  132 |         for( const auto& line : brep.lines() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:136:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  136 |             for( const auto& incident_surface : brep.incidences( line ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:138:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  138 |                 for( const auto& boundary_line :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:144:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  144 |                     if( const auto existing_edge = graph.edge_from_vertices(
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:147:25: note: +5, including nesting penalty of 4, nesting level increased to 5
  147 |                         if( surface_uuids_to_graph_edges
      |                         ^

  • src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:119:10: warning: [readability-function-size]

    function 'create_graph' exceeds recommended size/complexity thresholds

      119 |     void create_graph( const geode::BRep& brep,
      |          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:119:10: note: 5 parameters (threshold 4)

  • src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:163:32: warning: [readability-function-cognitive-complexity]

    function 'find_not_boundary_surfaces' has cognitive complexity of 33 (threshold 10)

      163 |     std::vector< geode::uuid > find_not_boundary_surfaces(
      |                                ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:176:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  176 |         while( found_not_boundary_surface )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:179:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  179 |             for( const auto graph_vertex :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:182:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  182 |                 if( graph->edges_around_vertex( graph_vertex ).empty() )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:193:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  193 |                 for( const auto& edge_around :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:196:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  196 |                     if( surface_uuids_to_graph_edges
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:205:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  205 |                 if( !should_delete )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:209:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  209 |                 if( absl::c_contains( not_boundaries_surfaces, surface_id ) )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:213:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  213 |                 for( const auto& edge :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:220:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  220 |             if( !absl::c_contains( to_delete, true ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:228:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  228 |             for( const auto& [surface_id, graph_edges] :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:231:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  231 |                 for( const auto graph_edge : graph_edges )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:233:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  233 |                     if( old2new.at( graph_edge ) != geode::NO_ID )
      |                     ^

  • src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:400:50: warning: [readability-function-cognitive-complexity]

    function 'fuse_brep_surfaces_from_list' has cognitive complexity of 11 (threshold 10)

      400 |     std::unique_ptr< geode::PolygonalSurface3D > fuse_brep_surfaces_from_list(
      |                                                  ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:409:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  409 |         for( const auto& surface_id : surface_list )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:413:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  413 |             for( const auto polygon :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:418:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  418 |                 for( auto& polygon_vertex : polygon_vertices )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:422:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  422 |                     if( !unique_vertices_to_polygonal_surface_vertices
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:432:21: note: +1, nesting level increased to 4
  432 |                     else
      |                     ^

Have any feedback or feature suggestions? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panquez panquez panquez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BenPinet @panquez