Skip to content

bump urllib3 from 1.26.18 to 2.6.3#14045

Open
giohappy wants to merge 1 commit intomasterfrom
urllib3-2.6.3
Open

bump urllib3 from 1.26.18 to 2.6.3#14045
giohappy wants to merge 1 commit intomasterfrom
urllib3-2.6.3

Conversation

@giohappy
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Mar 13, 2026
@giohappy giohappy requested a review from mattiagiupponi March 13, 2026 17:48
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the urllib3 dependency to its latest stable version. This update ensures the project benefits from the most recent features, performance improvements, and critical security patches provided by the library, enhancing overall stability and compatibility.

Highlights

  • Dependency Update: Updated the urllib3 dependency from version 1.26.18 to 2.6.3.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • pyproject.toml
    • Updated the urllib3 dependency version.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates urllib3 from version 1.26.18 to 2.6.3. This is a major version upgrade which introduces several breaking changes. While the project's direct dependencies like requests seem to be compatible, there is a risk that other transitive dependencies are not, or that the application's behavior could be affected by these breaking changes. I've added a comment highlighting the risks and recommending thorough testing to mitigate any potential issues.

"beautifulsoup4==4.12.3",
"hyperlink==21.0.0",
"urllib3==1.26.18",
"urllib3==2.6.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Bumping urllib3 from a 1.x version to a 2.x version is a major update that includes breaking changes. This could lead to runtime errors if other parts of the application or other dependencies are not compatible with urllib3 v2.

Some of the breaking changes in urllib3 v2 include:

  • Removal of urllib3.contrib.pyopenssl.
  • Changes in the Retry class API.
  • Removal of HTTPResponse.getheaders() and HTTPResponse.getheader().
  • The default value of preload_content in request() is now True.

It is highly recommended to perform thorough integration and regression testing to ensure that the application continues to function correctly after this update. The pull request description should also be updated to mention this major dependency change and the testing that was performed.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.19%. Comparing base (7f6c030) to head (09c3c5f).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14045      +/-   ##
==========================================
- Coverage   74.07%   66.19%   -7.88%     
==========================================
  Files         950      951       +1     
  Lines       56826    57352     +526     
  Branches     7719     7782      +63     
==========================================
- Hits        42093    37966    -4127     
- Misses      13044    17811    +4767     
+ Partials     1689     1575     -114     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant