Closed
Conversation
Release v0.9.4
Release v0.9.5
feat: allows customize email templates
|
As per discussion in Slack, I think a different approach is needed to meet the goal of keeping the upstream sync working, alongside deploying using We can do a few things:
I can take a look at helping with these if everyone is happy to this approach. Looking at the fastschema repo, the 3 commits they have on master ahead of develop are literally just the pull request merge commits |
This was referenced Mar 31, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to align with the latest tag in the origin
github.com/fastschema/fastschemaby rebasing tomaster.Current status:
fastschema/fastschemahasdevelopas default branch, which is onv0.9.4fastschema/fastschema'slatestandv0.9.6tag is onmasterbranch, is 3 commits ahead ofdevelopGeoNet/fastschemaforked fromfastschema/fastschemaand usingdevelopas default branch, too.HEADofGeoNet/fastschema, which is based onv0.9.4Issue:
go get github.com/fastschema/fastschemayou got v0.9.6 => this is expectedgo get github.com/GeoNet/fastschemayou got v0.9.6 => this DOESN'T INCLUDE OUR CHANGES. instead, you need togo get GitHub.com/GeoNet/fastschema@developto get to the HEAD that contains our updates.That's this PR for: to be able to use
go get GitHub.com/GeoNet/fastschemato get our HEAD which contains our updates.Note:
Cannot use
import github.com/GeoNet/fastschemain downstream Go code due to all the functions requirefastschema/fastschema.{something}type, notGeoNet/fastschema.{something}. So cannot change the import to GeoNet/fastschema. TheGeoNet/fastschemais more like a "GeoNet vendored fastschema/fastschema" instead of a dependency source.In the end, on the downstream application side, the go.mod looks like:
Which looks confusing. So I'm trying to make
GeoNet/fastschma v0.9.6-{pesudo version}