Skip to content

Fix(finstripe): resolve missing cross-vendor ownership guard in create_transfer #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jean-Regis-M wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Fix(finstripe): resolve missing cross-vendor ownership guard in create_transfer #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions finbot/mcp/servers/finstripe/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,13 @@ def create_transfer(
Transfers funds from the company account to a vendor's bank account.
Returns the transfer details including a unique transfer ID for tracking.
"""
if (
getattr(session_context, "portal_type", None) == "vendor"
and getattr(session_context, "current_vendor_id", None) is not None
and session_context.current_vendor_id != vendor_id
):
return {"error": "Vendor session can only initiate transfers to own account"}

transfer_id = _generate_transfer_id()

with db_session() as db:
Expand Down
Loading