Fix(findrive): reject empty/whitespace filenames before DB write in upload_file#436
Open
Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Open
Fix(findrive): reject empty/whitespace filenames before DB write in upload_file#436Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Conversation
Root cause: upload_file had no presence check on filename, allowing repo.create_file() to persist unresolvable ghost records with empty filenames. Solution: Added `if not filename or not filename.strip()` guard before DB write, returning a structured error consistent with existing tool error responses. Impact: No breaking changes. Deterministic early return. Zero DB side effects on invalid input. Signed-off-by: JEAN REGIS <240509606@firat.edu.tr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #366
Adds missing filename presence validation to
upload_file, preventingghost records from being created with empty or whitespace-only filenames.
Problem
upload_file(filename='', content='data')bypassed all validation andcalled
repo.create_file(filename='', ...), persisting an unresolvablerecord in the file index.
Root Cause
upload_filevalidatedcontentsize but had no guard onfilename,allowing empty strings to reach the repository layer unconditionally.
Solution
Added a two-condition guard (
not filename or not filename.strip()) asthe first check in
upload_file, returning{"error": "Filename must not be empty"}before any DB interaction occurs.Impact
Testing