Fix(findrive): resolve path traversal validation gap in upload_file#435
Open
Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Open
Fix(findrive): resolve path traversal validation gap in upload_file#435Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Conversation
Root cause: upload_file passed filename directly to repo.create_file() without validating for ".." components or absolute paths, allowing traversal sequences to be stored unchecked. Solution: Added early-return guard checking for ".." in filename or leading "/" immediately after the existing size check, before any DB interaction. Impact: No breaking changes. Valid filenames unaffected. Deterministic rejection of traversal inputs. Zero regression risk. Signed-off-by: JEAN REGIS <240509606@firat.edu.tr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #359
Rejects filenames containing
..or a leading/before any database write occurs.Problem
upload_fileaccepted filenames such as../../../etc/passwdwithout validation,passing them directly to
repo.create_file(). If filenames are used in filesystemoperations downstream, this enables directory escape and arbitrary file read/write.
Root Cause
No path traversal check existed between parameter ingestion and
repo.create_file().The size check was the only guard; filename content was entirely trusted.
Solution
Added two-condition guard immediately after the size check:
Consistent with existing early-return error style. No other lines changed.
Impact
Testing