GRCAN Viewer Improvements#441
Open
coderask wants to merge 57 commits into
Open
Conversation
dchansen06
force-pushed
the
viewer_improvements
branch
from
5d1485c to
0e0191c
Compare
dchansen06
added
Documentation
dchansen06
requested changes
May 11, 2026
Contributor
There was a problem hiding this comment.
Additionally we need to get can_groups.json and can_topology.json into the source GRCAN.CANdo with how much work is going on in different branches right now (namely tire temp, SAMMs, ECU). I know I previously said it would work as a holdover but right now all other branches are manually doing it and I would like to not further prolong that if avoidable.
Also, is there a way for the DBC to shorten the names without breaking the struct names? This may cause serious problems for LV-test in #450 which has done a lot of work and will have breakages/etc...
dchansen06
reviewed
May 11, 2026
Signed-off-by: coderask <62189577+coderask@users.noreply.github.com>
: Lots... Work with @an0tv and @vin-shin to test ECU on their floor and fix all the bugs we can find Identified and fixed many bugs but there are some boards that have not been tested against, it is a good start - [ ] HOOTL testing - [x] HITL testing - [x] Human tested Lots of human testing Part of larger LV testing Resolves #166 --------- Signed-off-by: Daniel Hansen <105574022+dchansen06@users.noreply.github.com> Signed-off-by: Daniel Hansen <dchansen06@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: khoulihan27 <khoulihan@ucsb.edu> Co-authored-by: Casey Zwicker <caseypzwicker@gmail.com> Co-authored-by: Vihan Jayaraman <55373538+VihanJ@users.noreply.github.com> Co-authored-by: Thomas Xu <thomasxu070224@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anthony Ma <anthony497@ucsb.edu> Co-authored-by: coderask <62189577+coderask@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Andrey <andreyotvagingrey@gmail.com> Co-authored-by: gr-jetson <team@gauchoracing.com> Co-authored-by: khoulihan27 <khoulihan27@users.noreply.github.com>
dchansen06
requested changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viewer Improvements
Problem and Scope
GRCAN Viewer needs more features.
Description
Graph View overhaul, Mobile device support, etc.
Gotchas and Limitations
Sticking with a strict simple js project.
Testing
Testing Details
Larger Impact
Additional Context and Ticket