Skip to content

Comments

CAN ISR#248

Draft
VihanJ wants to merge 20 commits intomainfrom
CAN_ISR
Draft

CAN ISR#248
VihanJ wants to merge 20 commits intomainfrom
CAN_ISR

Conversation

@VihanJ
Copy link
Contributor

@VihanJ VihanJ commented Feb 23, 2026 •
edited by dchansen06
Loading

CAN ISR

Problem and Scope

  • CAN library to handle circular buffer logic for tx (may implement rx later, if needed)

Description

Gotchas and Limitations

  • may need to use a hardware timer for draining TX_buffer
  • unit tests are not written yet, big issue

Testing

  • HOOTL testing
  • HITL testing
  • Human tested

Testing Details

Larger Impact

Additional Context and Ticket

ahoysal and others added 17 commits January 26, 2026 20:58
@ahoysal
added id to CAN RX callback
da4a67e
@ahoysal
Added enum as CAN identifier in RX
05214b4
@github-actions
Automatic CMake Format: Standardized formatting automatically
9261965
@github-actions
Automatic Clang-Format: Standardized formatting automatically
f26d44f
@VihanJ
Changed CAN_RX_Callback to take in ID, data, size
d36a3ba
@github-actions
Automatic Clang-Format: Standardized formatting automatically
9e1af22
@github-actions
Automatic CMake Format: Standardized formatting automatically
499d15c
@VihanJ
added formatting for uint32_t id in can_tests.c
4337a58
@github-actions
Automatic Clang-Format: Standardized formatting automatically
2b00473
@VihanJ
cleand up can.c
98923cf
@VihanJ
added basepri masking, also tried to prevent spurious NVIC interrupts…
82e7709 
… in can_start and can_stop
@VihanJ
added basepri masking, also tried to prevent spurious NVIC interrupts…
6d6d9ff 
… in can_start and can_stop
@VihanJ
Refactored to use statically sized spsc buffer
18af90b
@VihanJ
passed human testing
ebc37b8
@VihanJ
added notes in readme
7245169
@VihanJ
Merge remote-tracking branch 'origin/main' into CAN_ISR
28b8e14 
Was behind by 17 commits, merged at request of Daniel H.
@VihanJ
tried to fix CAN data baud rate in ECU/Core/Src/main.c
1b2adde
@VihanJ VihanJ requested a review from dchansen06 as a code owner February 23, 2026 02:58
@dchansen06 dchansen06 changed the title Can isr CAN ISR Feb 23, 2026
@dchansen06 dchansen06 added Enhancement New feature or request 2 PRIORITY Important and a priority, but less than URGENT Big Fry Something that is complex and/or large Peripheral Related to or involving a peripheral including abstractions labels Feb 23, 2026
@dchansen06 dchansen06 linked an issue Feb 23, 2026 that may be closed by this pull request
CAN Peripheral Abstractions #31
Closed
@dchansen06 dchansen06 marked this pull request as draft February 23, 2026 04:32
@dchansen06 dchansen06 removed the 2 PRIORITY Important and a priority, but less than URGENT label Feb 23, 2026
@dchansen06 dchansen06 added the 1 URGENT Urgent issue that needs a quick action and resolution label Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dchansen06 dchansen06 Awaiting requested review from dchansen06 dchansen06 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ahoysal ahoysal

@VihanJ VihanJ

@nacsoprog nacsoprog

Labels

1 URGENT Urgent issue that needs a quick action and resolution Big Fry Something that is complex and/or large Enhancement New feature or request Peripheral Related to or involving a peripheral including abstractions

Projects

None yet

Milestone

GR26 - Firmware Feature Freeze

Development

Successfully merging this pull request may close these issues.

CAN Peripheral Abstractions

4 participants

@VihanJ @ahoysal @dchansen06 @nacsoprog