Skip to content

Debug bad walled area shape in town scene #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gambitnl wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Debug bad walled area shape in town scene #4

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5a8ba53
Implement ray casting algorithm for point-in-polygon test
cursoragent Aug 4, 2025
1227e0d
Refactor: Update imports, add methods, and improve type handling
cursoragent Aug 4, 2025
6fb3b34
Migrate project to Vite, update build and dev scripts
cursoragent Aug 4, 2025
3bf8251
Improve model generation, error handling, and polygon point-in-polygo…
cursoragent Aug 4, 2025
253ee62
Refactor web app with modern UI, improved generation, and responsive …
cursoragent Aug 4, 2025
1123bf5
Update August 6, 2025. 12:22AM
Gambitnl Aug 5, 2025
834faa0
Update AUgust 6 2025, 12:33AM
Gambitnl Aug 5, 2025
cbe2127
Update August 6 2025, 12:39AM
Gambitnl Aug 5, 2025
aa5edee
Update August 6 2025, 01:15AM
Gambitnl Aug 5, 2025
8ff4e2c
Update August 6 2025, 01:17AM
Gambitnl Aug 5, 2025
fee8a41
Update August 6 2025, 15:38PM
Gambitnl Aug 6, 2025
236bc85
Update August 6 2025, 21:25PM
Gambitnl Aug 6, 2025
916119a
Upgrade August 6 2025, 23:46PM
Gambitnl Aug 6, 2025
30fdb32
Update August 7 2025, 21:16PM
Gambitnl Aug 7, 2025
71f08c8
Update August 7 2025, 12:00:00 AM
Gambitnl Aug 7, 2025
9aa481e
Update August 11 2025, 01:09AM
Gambitnl Aug 10, 2025
2f50ec1
Update August 12 2025, 21:43PM
Gambitnl Aug 12, 2025
ebbe01f
Update August 12 2025, 23:34PM
Gambitnl Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion web/src/types/polygon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,17 @@ export class Polygon {
}

public contains(v: Point): boolean {
return this.vertices.some(p => p.x === v.x && p.y === v.y);
// Ray casting algorithm for point-in-polygon test
let inside = false;
for (let i = 0, j = this.vertices.length - 1; i < this.vertices.length; j = i++) {
const xi = this.vertices[i].x, yi = this.vertices[i].y;
const xj = this.vertices[j].x, yj = this.vertices[j].y;

const intersect = ((yi > v.y) !== (yj > v.y)) &&
(v.x < (xj - xi) * (v.y - yi) / (yj - yi) + xi);
if (intersect) inside = !inside;
}
return inside;
}
Comment on lines 65 to 104
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The new implementation correctly identifies points strictly inside the polygon, which fixes the described bug. This is a great improvement!

However, there's a subtle change in behavior for points on the boundary. The previous implementation returned true for vertices, but the new ray-casting algorithm will return false for all points on the boundary, including vertices.

This could lead to unexpected behavior if other parts of the code rely on contains being true for vertices.

To restore the previous behavior for vertices while keeping the new, correct check for interior points, I suggest adding the vertex check back at the beginning of the method. This is a minimal change that addresses the regression for vertices.

Note that with this change, points on an edge that are not vertices will still be considered outside. A full boundary check would be more robust but also more complex.

    public contains(v: Point): boolean {
        // The previous implementation returned true for vertices. To maintain this behavior
        // for vertices while correctly checking for interior points, we can check for
        // vertex containment first. Note that other points on the boundary will still
        // be considered outside with this approach.
        if (this.vertices.some(p => p.x === v.x && p.y === v.y)) {
            return true;
        }

        // Ray casting algorithm for point-in-polygon test
        let inside = false;
        for (let i = 0, j = this.vertices.length - 1; i < this.vertices.length; j = i++) {
            const xi = this.vertices[i].x, yi = this.vertices[i].y;
            const xj = this.vertices[j].x, yj = this.vertices[j].y;

            const intersect = ((yi > v.y) !== (yj > v.y)) &&
                (v.x < (xj - xi) * (v.y - yi) / (yj - yi) + xi);
            if (intersect) inside = !inside;
        }
        return inside;
    }


public forEdge(f: (v0: Point, v1: Point) => void): void {
Expand Down