Skip to content

Flip to WFI coords and document the flip #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmjarvis merged 2 commits into from
Aug 4, 2026
+6 −0
Merged

Flip to WFI coords and document the flip #1363

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30f1756
Flip to WFI coords and document the flip
nihardalal Aug 4, 2026
e70e9c2
Fixed to use galsim transformation isntead
nihardalal Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions galsim/roman/roman_psfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,12 @@ def __make_aperture(SCA, pupil_plane_type, pupil_bin, wave, gsparams):

pupil_plane_im = pupil_plane_im.bin(pupil_bin,pupil_bin)

#The project provides pupils in the exit frame orientation. To switch to WFI coords, we need to flip following:
#https://github.com/Roman-HLIS-Cosmology-PIT/PSFSim/blob/main/docs/coordinates.rst, which has the chirality
#looking in the telescope. Can be accomplished by flipping the vertical axis.

pupil_plane_im = pupil_plane_im.flip_ud()

aper = Aperture(lam=wave, diam=diameter,
obscuration=obscuration,
pupil_plane_im=pupil_plane_im,
Expand Down
Loading