Skip to content

Add BQu mixin#359

Merged
tier940 merged 2 commits intomasterfrom
tier-fix-bqu
Feb 11, 2026
Merged

Add BQu mixin#359
tier940 merged 2 commits intomasterfrom
tier-fix-bqu

Conversation

@tier940
Copy link
Member

@tier940 tier940 commented Feb 11, 2026

No description provided.

@tier940 tier940 self-assigned this Feb 11, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tier940, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces Better Questing (BQu) integration, enabling its use as a debug dependency and ensuring proper mod loading. A significant client-side fix addresses an issue with the "Update Available!" button in Better Questing, allowing it to correctly handle modern quest pack formats. Additionally, the PR streamlines existing integration configurations by removing obsolete hardToolRecipes settings from AE, EIO, and TC modules, simplifying the codebase.

Highlights

  • Better Questing Integration: Added Better Questing (BQu) as a debug dependency and integrated it into the mod loading system.
  • Better Questing Update Button Fix: Implemented a client-side mixin to correct the "Update Available!" button functionality in Better Questing, allowing it to properly load directory-based quest packs.
  • Configuration Cleanup: Removed redundant hardToolRecipes configuration options from Applied Energistics (AE), Ender IO (EIO), and Thaumcraft (TC) integration modules.
Changelog
  • buildscript.properties
    • Added a debug flag for Better Questing (debug_bqu).
  • dependencies.gradle
    • Included Better Questing (BQu) as a compile-only and conditional runtime dependency.
  • src/main/java/com/github/gtexpert/core/api/util/Mods.java
    • Added BetterQuesting to the Mods enum and its corresponding name constant.
  • src/main/java/com/github/gtexpert/core/integration/ae/AEConfigHolder.java
    • Removed the hardToolRecipes configuration option.
  • src/main/java/com/github/gtexpert/core/integration/ae/recipes/AEToolsRecipe.java
    • Updated the recipe initialization logic to remove the AEConfigHolder.hardToolRecipes condition.
  • src/main/java/com/github/gtexpert/core/integration/eio/EnderIOConfigHolder.java
    • Removed the hardToolArmorRecipes configuration option.
  • src/main/java/com/github/gtexpert/core/integration/eio/recipes/EIOToolsRecipe.java
    • Updated the recipe initialization logic to remove the EnderIOConfigHolder.hardToolArmorRecipes condition.
  • src/main/java/com/github/gtexpert/core/integration/tc/TCConfigHolder.java
    • Removed the hardToolRecipes configuration option.
  • src/main/java/com/github/gtexpert/core/integration/tc/recipes/TCToolsRecipe.java
    • Updated the recipe initialization logic to remove the TCConfigHolder.hardToolRecipes condition.
  • src/main/java/com/github/gtexpert/core/mixins/GTEMixinLoader.java
    • Added Mods.Names.BETTER_QUESTING to the modMixinsConfig map.
  • src/main/java/com/github/gtexpert/core/mixins/betterquesting/GuiHomeUpdateMixin.java
    • Added a new mixin class to fix the "Update Available!" button in Better Questing's home GUI.
  • src/main/resources/mixins.gtexpert.betterquesting.json
    • Added a new Mixin configuration file for Better Questing client-side mixins.
Activity
  • No specific activity (comments, reviews, progress) was provided in the context for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストは、BetterQuesting (BQu) の統合を追加し、関連するデバッグ設定とMixinを導入しています。また、AE2、EnderIO、Thaumcraftのツールレシピ設定から冗長なhardToolRecipesフラグを削除し、コードの簡素化を図っています。全体的に変更は意図通りですが、dependencies.gradleファイルに小さな論理エラーがあります。

@tier940 tier940 merged commit e7f35ec into master Feb 11, 2026
3 checks passed
@tier940 tier940 deleted the tier-fix-bqu branch February 11, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant