Skip to content

Fix server boot crash#358

Merged
tier940 merged 2 commits intomasterfrom
tier-fix-server-boot
Feb 10, 2026
Merged

Fix server boot crash#358
tier940 merged 2 commits intomasterfrom
tier-fix-server-boot

Conversation

@tier940
Copy link
Member

@tier940 tier940 commented Feb 10, 2026

No description provided.

@tier940 tier940 self-assigned this Feb 10, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tier940, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical server boot crash by isolating client-specific mixin code. The logic responsible for conditionally hiding the auto-eat tooltip on the QuarkTechSuite item, which previously resided in a mixin loaded on both client and server, has been moved to a new client-only mixin. This prevents client-dependent classes from being loaded in a server environment, thereby ensuring stable server startup.

Highlights

  • Mixin Refactoring: Client-side tooltip logic for the QuarkTechSuite was extracted from the general QuarkTechSuiteMixin into a new, dedicated QuarkTechSuiteClientMixin.
  • Server Stability: This refactoring ensures that client-specific code, which caused a server boot crash, is no longer loaded on the server, improving stability.
  • Configuration Preservation: The functionality to hide the auto-eat tooltip based on configuration (GTEConfigHolder.ceuOverride.disableHelmetAutoEat) remains intact within the new client-only mixin.
Changelog
  • CHANGELOG.md
    • Added new version 2.7.1 entry, documenting the fix for a server boot crash.
  • src/main/java/com/github/gtexpert/core/mixins/gregtech/QuarkTechSuiteClientMixin.java
    • Added a new client-only mixin to handle the auto-eat tooltip visibility for QuarkTechSuite.
  • src/main/java/com/github/gtexpert/core/mixins/gregtech/QuarkTechSuiteMixin.java
    • Removed client-side tooltip handling and related imports, streamlining the mixin for server compatibility.
  • src/main/resources/mixins.gtexpert.gregtech.json
    • Registered the newly created QuarkTechSuiteClientMixin under the client mixin configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストは、サーバー起動時に発生していたクラッシュを修正するものです。原因は、クライアントサイド専用のクラス(net.minecraft.client.resources.I18n)を共通のMixinで使用していたことでした。

この修正では、クライアントサイドのロジックを専用のクライアントMixin (QuarkTechSuiteClientMixin) に分離しています。これは、このような問題を解決するための適切でクリーンなアプローチです。

全体として、これは素晴らしい修正です。1点、null安全に関する軽微な改善提案をさせていただきました。

@tier940 tier940 merged commit 0a12119 into master Feb 10, 2026
2 checks passed
@tier940 tier940 deleted the tier-fix-server-boot branch February 10, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant