Skip to content

fix(ci): match BREAKING CHANGE only as a footer in skip probe #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GSTJ merged 1 commit into from
May 19, 2026
Merged

fix(ci): match BREAKING CHANGE only as a footer in skip probe #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,33 @@ jobs:
BOUNDARY=$(echo "$CANDIDATES" | xargs -I{} git log -1 --pretty="%ct %H" {} 2>/dev/null | sort -rn | head -1 | awk '{print $2}')
echo "boundary=$BOUNDARY ($(git log -1 --pretty=%s "$BOUNDARY"))"

# `\(modal\)` matches scoped commits; `BREAKING[- ]CHANGE` matches
# the footer added by conventional-commits for breaking changes.
QUALIFY=$(git log "$BOUNDARY..HEAD" -E --grep='\(modal\)|BREAKING[- ]CHANGE' --pretty=%s || true)
# A commit qualifies if EITHER:
# - its subject (first line) has `(modal)` scope, OR
# - its body contains a line starting with `BREAKING CHANGE:`
# or `BREAKING-CHANGE:` (the conventional-commits footer).
# We can't use `git log --grep` here because that searches the
# entire commit message; a PR description that mentions
# "BREAKING CHANGE" in prose would falsely match. Iterate
# commits with a unit separator and check each part explicitly.
UNIT=$'\x1f'
REC=$'\x1e'
COMMITS=$(git log "$BOUNDARY..HEAD" --pretty=format:"%H${UNIT}%s${UNIT}%b${REC}")
QUALIFY=""
Comment on lines +117 to +120
while IFS= read -r -d "$REC" entry; do
[ -z "$entry" ] && continue
sha=$(printf '%s' "$entry" | awk -F"$UNIT" '{print $1}')
subject=$(printf '%s' "$entry" | awk -F"$UNIT" '{print $2}')
body=$(printf '%s' "$entry" | awk -F"$UNIT" '{for(i=3;i<=NF;i++) printf "%s%s", $i, (i<NF?FS:"")}')
Comment on lines +123 to +125
if printf '%s' "$subject" | grep -q '(modal)'; then
QUALIFY="${QUALIFY}${subject}"$'\n'
continue
fi
if printf '%s' "$body" | grep -qE '^BREAKING[- ]CHANGE:'; then
QUALIFY="${QUALIFY}${subject}"$'\n'
fi
done <<< "$COMMITS"
QUALIFY=$(printf '%s' "$QUALIFY" | sed '/^$/d')

if [ -z "$QUALIFY" ]; then
echo "No qualifying commits since boundary. Skipping release."
echo "skip=true" >> "$GITHUB_OUTPUT"
Expand Down
Loading