fix(ci): unblock release git push + docs caching#186
Merged
Conversation
Two post-7.0.1 ship issues: 1. The release workflow's npm publish step succeeds, but release-it then fails pushing the version-bump commit + tag back to main because GITHUB_TOKEN can't bypass branch protection. Switch the checkout to use the existing GH_PAT secret so release-it's git push goes through. 2. The docs workflow re-runs in seconds because turbo's `docs` task only declares its cache marker file as an output, not the generated `docs/` directory. The subsequent tar step then fails with "packages/modal/docs: Cannot open: No such file or directory". Add `docs/**` to the task outputs so turbo restores it on cache hit.
There was a problem hiding this comment.
Pull request overview
This PR addresses two CI workflow regressions that surfaced after the 7.0.1 release process started running end-to-end: (1) release-it failing to push the version bump commit/tag due to branch protection, and (2) docs deployments failing on Turbo cache hits because generated docs weren’t treated as cached outputs.
Changes:
- Update the release workflow checkout to use a PAT (
secrets.GH_PAT) sorelease-itcan push commits/tags tomainunder branch protection. - Expand the Turbo
docstask outputs to include the generateddocs/**directory so cache hits restore docs artifacts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
turbo.json |
Adds docs/** to Turbo task outputs so docs generation artifacts are restored on cache hits. |
.github/workflows/release.yml |
Uses secrets.GH_PAT for checkout credentials to unblock release-it git push to main. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
expo-doctor on main started failing because npm shipped expo@55.0.25 and expo-router@55.0.15 since the SDK upgrade landed. Lockfile refresh brings the example into compliance.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two post-7.0.1 ship issues, observed in CI runs after #179 merged:
🚀 Publish step succeeds with
npm publishbut release-it then fails pushing the version-bump commit + tag back to main:GH013: Repository rule violations found for refs/heads/main(GITHUB_TOKENcan't bypass branch protection). Switch the checkout tosecrets.GH_PATso release-it's git push goes through.📚 Docs workflow finishes in 5s and then errors with
tar: packages/modal/docs: Cannot open: No such file or directory. Cause: turbo'sdocstask only declaresnode_modules/.cache/docs.jsonas an output, so on cache hit turbo doesn't restore the generateddocs/directory. Adddocs/**to the task outputs.Both issues are pre-existing in the workflows but only surfaced now that the Publish workflow actually gets past pnpm setup + npm auth.
Test plan
pnpm typecheckgreen