-
Notifications
You must be signed in to change notification settings - Fork 39
GPII-4517: Added workflow for github actions #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 7 commits
f0bddf2
bc79436
bab3770
94af4a3
8e8d1ed
019e5e9
5156e59
0e050b7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| name: gpii-windows node tests | ||
|
|
||
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: windows-latest | ||
| env: | ||
| VCTargetsPath: 'C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\v140' | ||
| steps: | ||
| - uses: javihernandez/setup-node-nvm@input-arch-field | ||
| with: | ||
| node-version: "10.11.0" | ||
| node-arch: "32" | ||
| node-mirror: "https://nodejs.org/download/release/" | ||
|
|
||
| - uses: actions/checkout@v2 | ||
| - run: ./provisioning/CouchDB.ps1 | ||
| - uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: '2.7.17' | ||
|
|
||
| - name: Install vcbuildtools | ||
| run: choco install vcbuildtools -ia '/InstallSelectableItems VisualCppBuildTools_ATLMFC_SDK;VisualCppBuildTools_NETFX_SDK' -y | ||
| - name: Install Windows 10 SDK | ||
| run: choco install windows-sdk-10-version-1809-all --version=10.0.17763.1 -y | ||
| - name: Install MS Build Tools | ||
| run: choco install microsoft-build-tools -y | ||
| - name: Install VisualCppBuildTools | ||
| run: choco install visualcppbuildtools -y | ||
| - run: npm config set msvs_version 2015 --global | ||
| - run: npm config set python python2.7 | ||
|
|
||
| - run: npm install | ||
|
|
||
| - name: Pass linter | ||
| run: npx grunt lint | ||
|
|
||
| - name: Run node unit tests | ||
| run: node tests/UnitTests.js | ||
|
|
||
| - name: Run Acceptance builtIn tests | ||
| env: | ||
| GPII_TEST_COUCH_USE_EXTERNAL: 1 | ||
| run: node tests/AcceptanceTests.js builtIn | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ | |
| "dependencies": { | ||
| "edge-js": "10.3.1", | ||
| "ffi-napi": "2.4.3", | ||
| "gpii-universal": "0.3.0-dev.20200604T131823Z.d6fed9a", | ||
| "gpii-universal": "javihernandez/universal#f2972b9deeae48847a4ed951d1ab703b4e7bafc5", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Which commit is this - should we roll a release of it?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, the universal bits are in this PR GPII/universal#886 |
||
| "@pokusew/pcsclite": "0.4.18", | ||
| "ref": "1.3.4", | ||
| "ref-struct": "1.1.0", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth trying a few acceptance tests? Do they run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They would run, but if we want to run them as they are we'd need to set up couchdb. I can definitely take a look if there's an easy way to set up couchdb in the github-hosted windows images. I think I can even take a look at creating a small github action that sets up couchdb on windows (I already did something similar for our vagrant boxes), but again, I'd need some time.
Another option would be to run the acceptanceTests against a file-based prefsServer, which I think it's not the way we want to test things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So yeah, let me give a try at setting up couchdb, I'll keep you posted 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, here's the link to the CI pass https://github.com/javihernandez/windows/runs/1415137751?check_suite_focus=true