experimental: graphhopper upgrade fixes#116
Closed
MichaelsJP wants to merge 4 commits into
Closed
Conversation
OSMNodeData stored barrier node tags in a List<Map<String,Object>>, allocating a HashMap per tagged node. On a planet-scale import this produces millions of short-lived hash maps, driving GC pause time and ballooning heap pressure throughout the read pass. Backported KVStorage (com.graphhopper.search) to replace the list with a compact, MMAP-backed byte store. Tags are serialised once and looked up by index, eliminating per-node HashMap overhead entirely. When the fork is upgraded to a GH version that ships KVStorage natively, remove all ORS-GH BACKPORT markers in OSMNodeData.java plus KVStorage.java and the version constant.
MichaelsJP
changed the title
Member
|
We have agreed to refrain from these changes for now, primarily because backporting of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read our contributing guide and note that also your contribution falls under the Apache License 2.0 as outlined there.
Your first contribution should include a change where you add yourself to the CONTRIBUTORS.md file.