fix: Change hard-coded PorousSolid model for ALM#4062
Open
npillardou wants to merge 10 commits into
Open
Conversation
jafranc
reviewed
May 20, 2026
jafranc
approved these changes
May 20, 2026
Contributor
jafranc
left a comment
There was a problem hiding this comment.
Nice improvement ! Thanks
jhuang2601
approved these changes
May 20, 2026
Contributor
jhuang2601
left a comment
There was a problem hiding this comment.
It looks good!
Can you please add one smoke test with an inelastic model to the integratedTest?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the use of hard-coded Porous Solid model for ALM solver from :
PorousSolid< ElasticIsotropic, ConstantPermeability > to a type dispatch list.
This allows to setup other kind of mechanical model for matrix surrounding faults such as Drucker-Prager.
├── Contact
│ ├── AugmentedLagrangianMultipliers
│ │ └── ALM.ats
│ │
│ └── LagrangianMultipliers
│ └── LM.ats
│
├── DATATABLES
│ └── Files for imposed stress tables
│
├── EDFM
│ └── EDFM.ats
│
├── MESH
│
├── MULTIPHASE_TABLES
│ └── Files for multiphase flow tables
│
└── poromechanicsFractures.ats