Skip to content

fix: Change hard-coded PorousSolid model for ALM#4062

Open
npillardou wants to merge 10 commits into
developfrom
fix/npillardou/ALM-porous-solid-passthru
Open

fix: Change hard-coded PorousSolid model for ALM#4062
npillardou wants to merge 10 commits into
developfrom
fix/npillardou/ALM-porous-solid-passthru

Conversation

@npillardou
Copy link
Copy Markdown
Contributor

@npillardou npillardou commented May 20, 2026

This PR corrects the use of hard-coded Porous Solid model for ALM solver from :

PorousSolid< ElasticIsotropic, ConstantPermeability > to a type dispatch list.

This allows to setup other kind of mechanical model for matrix surrounding faults such as Drucker-Prager.

  • smoke test with Extended Drucker Prager on inclined Fault
  • Clean up of poromechanicsFracture folder with a hierarchy imposed as :

├── Contact
│ ├── AugmentedLagrangianMultipliers
│ │ └── ALM.ats
│ │
│ └── LagrangianMultipliers
│ └── LM.ats

├── DATATABLES
│ └── Files for imposed stress tables

├── EDFM
│ └── EDFM.ats

├── MESH

├── MULTIPHASE_TABLES
│ └── Files for multiphase flow tables

└── poromechanicsFractures.ats

@npillardou npillardou added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run code coverage enables running of the code coverage CI jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: bug Something isn't working flag: ready for review labels May 20, 2026
@jafranc jafranc self-requested a review May 20, 2026 07:52
Copy link
Copy Markdown
Contributor

@jafranc jafranc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement ! Thanks

Copy link
Copy Markdown
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!
Can you please add one smoke test with an inelastic model to the integratedTest?

@jhuang2601 jhuang2601 added EPIC - FF/Contact Contact mechanics type: feature New feature or request and removed type: bug Something isn't working labels May 20, 2026
@jhuang2601 jhuang2601 added flag: requires rebaseline Requires rebaseline branch in integratedTests and removed flag: no rebaseline Does not require rebaseline labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI EPIC - FF/Contact Contact mechanics flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants