Greeter UI - #312
Conversation
first version is limited to just showing addon and formatter versions
|
|
||
|
|
||
| func is_formatter_installed_locally() -> bool: | ||
| var binary_name := "gdscript-formatter" |
There was a problem hiding this comment.
This repeating logic was cleaned up into it's own method.
|
I'm leaving you a note just to say I'm not forgetting you. I've given this a try and a quick look on my last day off and there are some things we need to iron at. Notably it seems it doesn't account for the user editor scale settings well yet. I have limited free time so I couldn't yet review all the and make changes or send you review notes. I'll get to this as soon as possible with no it could take some time as I have busy weeks ahead |
|
Hi folks, since #305 is merged, would it make sense to implement this greeter in both the GDQuest_GDScript_formatter addon and the GDQuest_GDScript_formatter_standalone addon? |
|
Sure! I would just first like to take the time to thoroughly test it and make sure everything's working as well as it can so we don't have to revisit/maintain it much, review the code carefully, and then we can copy it over to the standalone add on. I just haven't had the time yet, unfortunately. |
3 participants
Please check if the PR fulfills these requirements:
Related issue (if applicable): #107
What kind of change does this PR introduce?
A new greeter UI which is shown when the addon is enabled. This provides access to the addon and formatter verions as well as quick access to key settings and useful resources like the documentation and issue tracker.
Does this PR introduce a breaking change?
No, it builds on top of what is already present.
New feature or change
What is the current behavior?
When the addon is enabled, no UI is shown.
What is the new behavior?
When the addon is enabled, a new greeter UI is shown.
Other information
Screenshots
Closes #107