perf(build): converge Reqwest on Rustls - #1993
Merged
limityan merged 1 commit intoAug 3, 2026
Merged
Conversation
Keep the workspace dependency transport-only, make HTTP client owners select Rustls explicitly, and guard the decoded/resolved feature graph against a second TLS backend. Remove the obsolete Windows OpenSSL bootstrap from local build scripts and existing workflows.
limityan
marked this pull request as ready for review
August 3, 2026 06:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tls_backend_rustls()and preserve platform certificate verificationThis is not another MCP architecture follow-up. MCP ownership and behavior are unchanged; its remote HTTP transport only participates in the repository-wide Reqwest backend convergence.
product-fullis not used as a convenience dependency gate.Architecture and scope
reqwestowns only the shared version plus HTTP/serialization/stream capabilitiesDependency impact
Cargo.lockdrops 5 packages:hyper-tls,native-tls,openssl,openssl-macros, andtokio-native-tls.openssl-sysremains only on the non-Windows Git/libgit2 path; it is absent from the Windows Desktop graph.Local verification
pnpm run check:core-boundaries:test? 40/40 passedpnpm run check:core-boundaries? passedcargo check --locked -p bitfun-services-integrations --no-default-features --features mcpcargo check --locked -p bitfun-ai-adapterscargo check --locked -p bitfun-desktopgit diff --check? passedRisk and follow-up
The behavioral change is the Review Platform client moving from Native TLS to the same Rustls platform verifier already used by the other Reqwest clients. The repository has no Reqwest client-identity or custom native connector usage. System-trusted certificates remain supported; untrusted self-signed certificates remain rejected by default. Live enterprise proxy/custom certificate environments were not manually exercised and remain CI/product validation evidence rather than a claimed local pass.
Remote CI