refactor(mcp): converge OAuth integration ownership - #1991
Merged
Conversation
Move concrete RMCP authorization and credential access behind the services integration owner. Keep Core's compatibility facade and product callback orchestration while routing Desktop credential status through the assembled manager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architecture boundary
Core's direct
rmcpmanifest edge changes from 1 to 0, andproduct-fullno longer selectsdep:rmcpdirectly. Services integrations remains the single direct RMCP owner. RMCP is still transitively present in full MCP products; this PR establishes ownership and does not claim to remove the full cold-build graph.Compatibility and scope
Dependency impact
rmcpdependencyproduct-fulldirectdep:rmcpselectionrmcpownerValidation
pnpm run check:core-boundaries:test(36/36)pnpm run check:core-boundariescargo test -p bitfun-services-integrations --no-default-features --features mcp --test mcp_contracts(42/42)cargo check -p bitfun-core --no-default-featurescargo test -p bitfun-core service::mcp::server::manager::auth_callback::tests::callback_page_prefers_the_product_locale_and_escapes_provider_errors -- --exactcargo test -p bitfun-core service::mcp::server::manager::tests::oauth_credentials_follow_the_manager_injected_data_dir -- --exactcargo check -p bitfun-desktop