-
-
Notifications
You must be signed in to change notification settings - Fork 17
feat: clarify File derivatives and add illegal char guideline #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -409,6 +409,28 @@ It is also acceptable to add more to previous changelogs (for example, adding mi | |
| - If you are unsure if a bump is needed, bump it. | ||
| - Follow appropriate changelog procedures outlined in the above section. | ||
|
|
||
| #### Illegal Char in Version String | ||
|
|
||
| In the case of an 'illegal character' in a `Version:{:rpmspec}` tag (such as a `-` or `/`), you will need to define a `%sanitized_ver:{:rpmspec}` macro. | ||
| To do this, add the following lines to your spec file (assuming a `-` is used in the upstream version): | ||
|
|
||
| ```rpmspec | ||
| %global ver UPSTREAM-VERSION | ||
| %global sanitized_ver %(echo %{ver} | sed 's/-//g') | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe replace to
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In what part?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh like adding a . instead of a /? I copied this from how most our current specs do it... but the . does make more sense
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Personally, I would change
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. actually why do we need this section? even if so this should be in fedora not us? |
||
| ... | ||
| Version: %sanitized_ver # This will expand to UPSTREAMVERSION in this example | ||
| ``` | ||
|
|
||
| Then, the `update.rhai` needs to be appended to replace the globaly defined `ver` instead of the usual `Version` tag. | ||
| Your `update.rhai` should look like this: | ||
|
|
||
| ```rhai | ||
| rpm.global("ver", gh("upstream/project")); // Remember to change the update function to what your upstream is hosted on, for example, `pypi()` or `hackage()`. | ||
| ``` | ||
|
|
||
| If a different illegal character is used, you will need to write a `sed` script to remove this character. | ||
| More information on writing these scripts can be found [here](https://linux.die.net/man/1/sed). | ||
|
|
||
| #### Patches | ||
|
|
||
| - Packages SHOULD apply patches (usually via the `-p*` flag) in `%autosetup{:rpmspec}`. If this is not possible (typically when `%autosetup{:rpmspec}` is not used), you SHOULD use [%autopatch](../rpm/macros#autopatch). | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now where is this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow this did not show up as missing on mobile LMAO