Fix rebuilding and keyboard timestamps on HashLink target#24
Merged
AbnormalPoof merged 6 commits intoFunkinCrew:mobile/mainfrom Mar 8, 2026
Merged
Fix rebuilding and keyboard timestamps on HashLink target#24AbnormalPoof merged 6 commits intoFunkinCrew:mobile/mainfrom
AbnormalPoof merged 6 commits intoFunkinCrew:mobile/mainfrom
Conversation
NotHyper-474
force-pushed
the
hashlink-patches
branch
3 times, most recently
from
f70a441 to
df7a722
Compare
NotHyper-474
force-pushed
the
hashlink-patches
branch
2 times, most recently
from
f686716 to
ac5396c
Compare
NotHyper-474
force-pushed
the
hashlink-patches
branch
from
ac5396c to
356ad75
Compare
NotHyper-474
force-pushed
the
hashlink-patches
branch
2 times, most recently
from
3c3d47a to
2062c90
Compare
NotHyper-474
force-pushed
the
hashlink-patches
branch
4 times, most recently
from
aa81cf9 to
18b9d68
Compare
NotHyper-474
force-pushed
the
hashlink-patches
branch
from
18b9d68 to
d1ceb08
Compare
NotHyper-474
force-pushed
the
hashlink-patches
branch
from
10f23bd to
bb2292c
Compare
This function wants the utf8 length, but text->length does not give this. We can instead use -1 to tell harfbuzz to treat it as null- terminating, which is the case with all hashlink strings anyway.
Haxe 5 defaults to 1.15, but we're currently still bundling an older version. So we need to specify hl-ver or it won't work properly because Haxe 5 will produce code that older HashLink isn't compatible with. If hl-ver is already specified, or if a custom HL_PATH is defined, does not set hl-ver because that may be undesirable.
Co-Authored-By: Josh Tynjala <joshtynjala@users.noreply.github.com>
… exist Better than this: Uncaught exception - std@sys_read_dir
gcc 15 changes the default standard from gnu17 to gnu23, but HashLink mysql won't build with gnu23. I confirmed that clang also supports gnu17 (and it is the documented default).
NotHyper-474
force-pushed
the
hashlink-patches
branch
from
bb2292c to
9b10f43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably would also require to bump HashLink to 1.15 to fix build issues on Linux.
I'll probably add pre-built HashLink binaries (although Windows and Lunix only) to this some time.I was indirectly informed you should not include binaries in your PR.