Skip to content

Andre Moon#2

Open
MoonMan120 wants to merge 6 commits intoFullstackAcademy:mainfrom
MoonMan120:main
Open

Andre Moon#2
MoonMan120 wants to merge 6 commits intoFullstackAcademy:mainfrom
MoonMan120:main

Conversation

@MoonMan120
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@monterojavier monterojavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to have your html files structured correctly 👌

Comment thread about.html
Comment on lines +34 to +43
</body>
<footer class="F1">
<a target="_blank" href="https://github.com/MoonMan120">
<img class="git" src="github-mark-white.png" alt="white github link" />
</a>
<a target="_blank" href="https://www.linkedin.com/in/andre-moon-148813185/">
<img class="linked" src="InBug-White.png" alt="linkedin logo" />
</a>
</body>
</footer>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Looks like you added a extra closing body tag
  • And you have the closing footer outside the body. You want to keep all the content inside the body

Comment thread contact.html
<img class="linked" src="InBug-White.png" alt="linkedin logo" />
</a>
</footer>
</html>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the html is the very last element in the file

Comment thread contact.html
Comment on lines +23 to +41
<footer class="F1">
<a target="_blank" href="https://github.com/MoonMan120">
<img class="git" src="github-mark-white.png" alt="white github link" />
</a>
<a target="_blank" href="https://www.linkedin.com/in/andre-moon-148813185/">
<img class="linked" src="InBug-White.png" alt="linkedin logo" />
</a>
</footer>
</html>

<section id="forms">
<form action="/url" method="GET">
<p>Enter name below:</p>
<input type="text">
<p>Email:</p>
<input type="text"> <br>
<button>submit</button>
</form>
</section> No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want all the content that is going to show on the page to be inside of the body tag

Take look at how this is written:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants