[Share By Email] Fix view model autoloading#490
Merged
Alkarex merged 1 commit intoJul 12, 2026
Conversation
Alkarex
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Models/View.phppathrss_urlfor compatibility with the legacysimplelayoutRoot cause
The view class was stored in
Models/View.phpbut declared and referenced asShareByEmail\mailers\View. The extension autoloader therefore looked for a non-existentmailers/View.phpfile. When loading failed, the controller and mailer fell back to the baseMinz_View, causing dynamic-property deprecation warnings on PHP 8.2 and an undefinedrss_urlwarning in the legacysimplelayout.Using
ShareByEmail\Models\Viewmakes the namespace resolve to the existing file and keeps all view data on declared typed properties.Fixes #210
Fixes #363
Validation
ShareByEmail\Models\ViewShareByEmail\mailers\Viewremainentry,to,subject,content, andrss_urlare declared on the view modelPHPStan and PHPCS were not run locally because PHP is unavailable in the local environment. They are expected to run in GitHub Actions.