Skip to content

[Share By Email] Preserve special characters in email subjects#489

Merged
Alkarex merged 1 commit into
FreshRSS:mainfrom
JamBalaya56562:fix/share-by-email-subject-entities
Jul 11, 2026
Merged

[Share By Email] Preserve special characters in email subjects#489
Alkarex merged 1 commit into
FreshRSS:mainfrom
JamBalaya56562:fix/share-by-email-subject-entities

Conversation

@JamBalaya56562

Copy link
Copy Markdown
Contributor

Summary

  • preserve special characters in Share By Email subjects instead of XML-encoding them
  • bump the Share By Email extension version to 0.3.4

Root cause

Minz_Request::paramString() XML-encodes special characters by default. As a result, a subject such as "word" was passed to PHPMailer as "word" and displayed that way by email clients.

Reading the subject with plaintext: true keeps the original text for PHPMailer, including quotation marks, ampersands, and non-ASCII characters.

Fixes #342

Validation

  • confirmed the default and plaintext: true behavior in Minz_Request::paramString()
  • reviewed the subject data flow from the POST parameter to ShareByEmail\mailers\Share and PHPMailer
  • confirmed the diff is limited to the Share By Email controller and metadata

PHPStan and PHPCS were not run locally because PHP is unavailable in the local environment. They are expected to run in GitHub Actions.

@Alkarex Alkarex merged commit 5c96b89 into FreshRSS:main Jul 11, 2026
1 check passed
@JamBalaya56562 JamBalaya56562 deleted the fix/share-by-email-subject-entities branch July 11, 2026 18:38

@mo74m3ed mo74m3ed left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Share By Email] HTML entities in email's subject

3 participants