Fix FT0011/FT0014/FT0015/FT0017 compliance findings in Frends.HTTP.Request - #59
Open
MatteoDelOmbra with Copilot wants to merge 5 commits into
Open
Fix FT0011/FT0014/FT0015/FT0017 compliance findings in Frends.HTTP.Request#59MatteoDelOmbra with Copilot wants to merge 5 commits into
MatteoDelOmbra with Copilot wants to merge 5 commits into
Conversation
…ends.HTTP.Request Co-authored-by: MatteoDelOmbra <44415151+MatteoDelOmbra@users.noreply.github.com>
…value Co-authored-by: MatteoDelOmbra <44415151+MatteoDelOmbra@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compliance findings in Frends.HTTP.Request
Fix FT0011/FT0014/FT0015/FT0017 compliance findings in Frends.HTTP.Request
Aug 17, 2026
| /// Additional error information, such as the original exception. | ||
| /// </summary> | ||
| /// <example>null</example> | ||
| public object AdditionalInfo { get; internal set; } |
Contributor
There was a problem hiding this comment.
change type to Exception
Contributor
Author
There was a problem hiding this comment.
Done — changed AdditionalInfo type from object to Exception in Error.cs (commit $(git rev-parse --short HEAD)).
MatteoDelOmbra
approved these changes
Aug 17, 2026
Co-authored-by: MatteoDelOmbra <44415151+MatteoDelOmbra@users.noreply.github.com>
Co-authored-by: MatteoDelOmbra <44415151+MatteoDelOmbra@users.noreply.github.com>
MatteoDelOmbra
approved these changes
Aug 18, 2026
MatteoDelOmbra
marked this pull request as ready for review
August 18, 2026 10:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves 7 task-analyzer findings in
Frends.HTTP.Request: missingSuccess/ErroronResult(FT0011), missing<example>tags onHeaderproperties (FT0014), missingThrowErrorOnFailure/ErrorMessageOnFailureonOptions(FT0015), and third-party type exposure onCertificateStoreLocation(FT0017).Changes
Definitions/Header.cs— added<example>tags toNameandValueOptions.cs— addedThrowErrorOnFailure(default: true) andErrorMessageOnFailure(default: "")Result.cs— addedSuccessandErrorproperties; consolidated the two success constructors into oneinternal Result(object body, …)+ addedinternal Result(bool success, Error error)for failure case; failure constructor setsStatusCode = -1as a sentinelError.cs(new) —Message+AdditionalInfopropertiesHelpers/ErrorHandler.cs(new)Standard error-handler extension following the required platform pattern. Every exception in
Request()now routes through it:When
ThrowErrorOnFailure = true(default) behavior is identical to before. Whenfalse, returnsResult { Success = false, Error = { Message, AdditionalInfo } }.Project / packaging
Frends.HTTP.Request.csproj: addedStyleCop.AnalyzersandFrendsTaskAnalyzersreferences; changedFrendsTaskMetadata.jsonfromNonetoAdditionalFiles(required for FT0020 to pass)Tests
ErrorHandlerTest.cs(new) — three NUnit tests covering throw-on-failure, return-result-on-failure, and custom error message, using an unreachable URL as the invalid-input trigger