Skip to content

Show a list of mods required to be enabled or disabled when mod is toggled#200

Open
dkhex wants to merge 1 commit into
FreesmTeam:developfrom
dkhex:feat_clarify_requirements_for_mod_toggle
Open

Show a list of mods required to be enabled or disabled when mod is toggled#200
dkhex wants to merge 1 commit into
FreesmTeam:developfrom
dkhex:feat_clarify_requirements_for_mod_toggle

Conversation

@dkhex

@dkhex dkhex commented Jul 4, 2026

Copy link
Copy Markdown

A simple QoL addition to "Confirm toggle/enable/disable" MessageBox.

Message example

… mod is toggled

Signed-off-by: dkhex <dk-hex@yandex.ru>
@arthursimao

Copy link
Copy Markdown
Contributor

I think the mod you wanted to disable is "Sable"

@dkhex

dkhex commented Jul 6, 2026

Copy link
Copy Markdown
Author

I think the mod you wanted to disable is "Sable"

Yes, I disable Sable (in this example), and now can see which mods will be also disabled if I click "Disable Required". And that's how it's looks in Freesm now:

Implicit disable

@kaeeraa

kaeeraa commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

lgtm

@notwindstone notwindstone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@notwindstone
notwindstone requested a review from so5iso4ka July 14, 2026 21:45

@so5iso4ka so5iso4ka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice feature, but what if there are too many mods listed in the message? You can't resize this dialog, at least on macOS. Here's what happens:

Image

Perhaps the simplest solution is to limit the number of mods in a string.

@dkhex

dkhex commented Jul 23, 2026

Copy link
Copy Markdown
Author

Okay, how many rows of text is acceptable for a QMessageBox? Or, maybe (if I don't be a lazy ass) I'll try to turn it into custom widget with scrollable list of affected mods.

@arthursimao

Copy link
Copy Markdown
Contributor

Okay, how many rows of text is acceptable for a QMessageBox? Or, maybe (if I don't be a lazy ass) I'll try to turn it into custom widget with scrollable list of affected mods.

There is no technical limit but for most users 1 to 3 rows is the most acceptable. but i think maybe 5/9 rows maybe?

@kaeeraa

kaeeraa commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

That's a nice feature, but what if there are too many mods listed in the message? You can't resize this dialog, at least on macOS. Here's what happens:

Image Perhaps the simplest solution is to limit the number of mods in a string.

QMessageBox has the detailedText property which allows to dialog contain text of any length

@kaeeraa

kaeeraa commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

so we can make to show like 5 mods and then "and N more mods..."

@kaeeraa kaeeraa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using setDetailedText() or add new constructor: instead of outputting each mod name in message clamp it to first five and add "and N mods more..." in the end
show full list in detailedText

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants