Skip to content

Modpack Creator Mode (Automatic Changelog Generation) #185

Merged
notwindstone merged 2 commits into
FreesmTeam:developfrom
arthursimao:modpack-creator
Jul 17, 2026
Merged

Modpack Creator Mode (Automatic Changelog Generation) #185
notwindstone merged 2 commits into
FreesmTeam:developfrom
arthursimao:modpack-creator

Conversation

@arthursimao

@arthursimao arthursimao commented May 16, 2026

Copy link
Copy Markdown
Contributor

This feature was implemented with the help of AI, as I don’t have experience with C++. Feedback, improvements, and refactoring suggestions are very welcome.

@notwindstone
notwindstone requested review from notwindstone and removed request for notwindstone May 16, 2026 15:46
@arthursimao arthursimao mentioned this pull request May 17, 2026
Closed
1 task
@notwindstone

notwindstone commented Jul 14, 2026

Copy link
Copy Markdown
Member

sorry for the long wait... and thanks for the contribution! we will review it and make changes (if needed) this week

@arthursimao

arthursimao commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

thanks :D

@arthursimao

arthursimao commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

make sure to take an really good review at it since it has been made by AI so... there will probably be errors :/

@so5iso4ka

so5iso4ka commented Jul 17, 2026

Copy link
Copy Markdown
Member

make sure to take an really good review at it since it has been made by AI so... there will probably be errors :/

That's why I delayed this review until the very last minute

First of all, tag your commits as described in CONTRIBUTING.md

I'll start reviewing it soon.

@so5iso4ka

so5iso4ka commented Jul 17, 2026

Copy link
Copy Markdown
Member

Could you also perform a rebase on the current develop branch? It's a little out of sync, and there's a minor conflict in the launcher/CMakeLists.txt file.

@arthursimao arthursimao changed the title Modpack Creator Mode (Automatic Changelog Generation) Modpack Creator Mode (Automatic Changelog Generation) Assisted-by: Claude/Gemini:Opus 4.6/3.1 Pro (High) [Antigravity] Jul 17, 2026
@so5iso4ka

so5iso4ka commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Tag the commit message, not the PR title; it should look something like this:

commit message

Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
Signed-off-by: Author name <Author email>

Also, why are the commits signed and authored by "FreesmModders"?

@arthursimao arthursimao changed the title Modpack Creator Mode (Automatic Changelog Generation) Assisted-by: Claude/Gemini:Opus 4.6/3.1 Pro (High) [Antigravity] Modpack Creator Mode (Automatic Changelog Generation) Jul 17, 2026
@VanTR0L

VanTR0L commented Jul 17, 2026

Copy link
Copy Markdown

Tag the commit, not the PR title; it should look something like this:

commit message

Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
Signed-off-by: Author name <Author email>

Also, why are the commits signed and authored by "FreesmModders"?

does he need to like git commit --amend for every existing commit in this PR and git push --force in the end?

@arthursimao

arthursimao commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Tag the commit message, not the PR title; it should look something like this:

commit message

Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
Signed-off-by: Author name <Author email>

Also, why are the commits signed and authored by "FreesmModders"?

I'm not sure how do i "tag an commit" i don't really know how to use git yknow the stuff i do in git is like just cloning an repository and stuff like that

@so5iso4ka

so5iso4ka commented Jul 17, 2026

Copy link
Copy Markdown
Member

does he need to like git commit --amend for every existing commit in this PR and git push --force in the end?

Actually, I don't really know, I do it in the IDE. But it will require a force push, yes.

@notwindstone

notwindstone commented Jul 17, 2026

Copy link
Copy Markdown
Member

Tag the commit message, not the PR title; it should look something like this:

commit message

Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
Signed-off-by: Author name <Author email>

Also, why are the commits signed and authored by "FreesmModders"?

I'm not sure how do i "tag an commit" i don't really know how to use git yknow the stuff i do in git is like just cloning an repository and stuff like that

let me do it for you

@arthursimao @notwindstone
feat: Implement Modpack Creator Mode with automatic changelog generation
cf3e59d 
Adds a new 'Modpack Creator' page to the instance settings dialog that
allows users to mark instances as their own modpacks and generate
changelogs automatically.

New files:
- ModpackChangelogGenerator.h/cpp: Core logic for creating version
  snapshots of the mod list and comparing them to detect added, removed,
  and updated mods based on mod IDs (not just names).
- ModpackCreatorPage.h/cpp/ui: Qt UI page with modpack toggle,
  metadata fields (name/author), changelog generation button, clipboard
  copy, and version history management.

Modified files:
- BaseInstance.h/cpp: Added ModpackCreatorEnabled, ModpackCreatorName,
  and ModpackCreatorAuthor settings with accessor methods.
- InstancePageProvider.h: Registered ModpackCreatorPage in the instance
  page list.
- CMakeLists.txt: Added all new source and UI form files.

Key features:
- One-click 'Mark as My Modpack' toggle per instance
- Automatic version snapshots stored as JSON in instance root
- Comparison logic categorizes changes into Added/Removed/Updated
- Clean formatted changelog output matching the requested format
- Copy to clipboard with visual feedback
- Version history with clear option
- Mod identification by mod_id for accuracy, with filename fallback

Assisted-by: Claude:claude-opus-4.6
Assisted-by: Google:gemini-3.1-pro
Signed-off-by: Arthur <111069131+arthursimao@users.noreply.github.com>
@arthursimao @notwindstone
fix: Adjust modpack creator workflow to compare with baseline
7a92646 
Assisted-by: Claude:claude-opus-4.6
Assisted-by: Google:gemini-3.1-pro
Signed-off-by: Arthur <111069131+arthursimao@users.noreply.github.com>
@notwindstone
notwindstone merged commit 2cfc69c into FreesmTeam:develop Jul 17, 2026
1 check passed
@notwindstone

notwindstone commented Jul 17, 2026

Copy link
Copy Markdown
Member

wait what 😭 i didn't merge it
how did we get there
i was upstreaming modpack-creator in your repo, then resolved a conflict, and it somehow triggered a pull request merge of this repo

image

@so5iso4ka

so5iso4ka commented Jul 17, 2026

Copy link
Copy Markdown
Member

rolled back

@notwindstone notwindstone mentioned this pull request Jul 17, 2026
Open
@notwindstone

notwindstone commented Jul 17, 2026

Copy link
Copy Markdown
Member

sorry, it's here now #207
when the changes are going to be merged (after our review and some changes), you will appear in the contributors tab

@s0me1newithhand7s

s0me1newithhand7s commented Jul 19, 2026

Copy link
Copy Markdown
Member
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@so5iso4ka so5iso4ka Awaiting requested review from so5iso4ka
@notwindstone notwindstone Awaiting requested review from notwindstone

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arthursimao @notwindstone @so5iso4ka @VanTR0L @s0me1newithhand7s