Skip to content

Fix MISRA C 2012 Rule 20.4: Replace #define static with STATIC macro #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elsonwei wants to merge 2 commits into
base: main
Choose a base branch
from
+99 −91
Open

Fix MISRA C 2012 Rule 20.4: Replace #define static with STATIC macro #1410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8306e9
Fix MISRA C 2012 Rule 20.4: Replace `#define static` with STATIC macro
elsonwei May 1, 2026
0d39d8b
Fix formating
elsonwei May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions croutine.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,24 +38,26 @@
* than file scope.
*/
#ifdef portREMOVE_STATIC_QUALIFIER
#define static
#define STATIC
#else
#define STATIC static
#endif


/* Lists for ready and blocked co-routines. --------------------*/
static List_t pxReadyCoRoutineLists[ configMAX_CO_ROUTINE_PRIORITIES ]; /**< Prioritised ready co-routines. */
static List_t xDelayedCoRoutineList1; /**< Delayed co-routines. */
static List_t xDelayedCoRoutineList2; /**< Delayed co-routines (two lists are used - one for delays that have overflowed the current tick count. */
static List_t * pxDelayedCoRoutineList = NULL; /**< Points to the delayed co-routine list currently being used. */
static List_t * pxOverflowDelayedCoRoutineList = NULL; /**< Points to the delayed co-routine list currently being used to hold co-routines that have overflowed the current tick count. */
static List_t xPendingReadyCoRoutineList; /**< Holds co-routines that have been readied by an external event. They cannot be added directly to the ready lists as the ready lists cannot be accessed by interrupts. */
STATIC List_t pxReadyCoRoutineLists[ configMAX_CO_ROUTINE_PRIORITIES ]; /**< Prioritised ready co-routines. */
STATIC List_t xDelayedCoRoutineList1; /**< Delayed co-routines. */
STATIC List_t xDelayedCoRoutineList2; /**< Delayed co-routines (two lists are used - one for delays that have overflowed the current tick count. */
STATIC List_t * pxDelayedCoRoutineList = NULL; /**< Points to the delayed co-routine list currently being used. */
STATIC List_t * pxOverflowDelayedCoRoutineList = NULL; /**< Points to the delayed co-routine list currently being used to hold co-routines that have overflowed the current tick count. */
STATIC List_t xPendingReadyCoRoutineList; /**< Holds co-routines that have been readied by an external event. They cannot be added directly to the ready lists as the ready lists cannot be accessed by interrupts. */

/* Other file private variables. --------------------------------*/
CRCB_t * pxCurrentCoRoutine = NULL;
static UBaseType_t uxTopCoRoutineReadyPriority = ( UBaseType_t ) 0U;
static TickType_t xCoRoutineTickCount = ( TickType_t ) 0U;
static TickType_t xLastTickCount = ( TickType_t ) 0U;
static TickType_t xPassedTicks = ( TickType_t ) 0U;
STATIC UBaseType_t uxTopCoRoutineReadyPriority = ( UBaseType_t ) 0U;
STATIC TickType_t xCoRoutineTickCount = ( TickType_t ) 0U;
STATIC TickType_t xLastTickCount = ( TickType_t ) 0U;
STATIC TickType_t xPassedTicks = ( TickType_t ) 0U;

/* The initial state of the co-routine when it is created. */
#define corINITIAL_STATE ( 0 )
Expand All @@ -80,15 +82,15 @@
* Utility to ready all the lists used by the scheduler. This is called
* automatically upon the creation of the first co-routine.
*/
static void prvInitialiseCoRoutineLists( void );
STATIC void prvInitialiseCoRoutineLists( void );

/*
* Co-routines that are readied by an interrupt cannot be placed directly into
* the ready lists (there is no mutual exclusion). Instead they are placed in
* in the pending ready list in order that they can later be moved to the ready
* list by the co-routine scheduler.
*/
static void prvCheckPendingReadyList( void );
STATIC void prvCheckPendingReadyList( void );

/*
* Macro that looks at the list of co-routines that are currently delayed to
Expand All @@ -98,7 +100,7 @@
* meaning once one co-routine has been found whose timer has not expired
* we need not look any further down the list.
*/
static void prvCheckDelayedList( void );
STATIC void prvCheckDelayedList( void );

/*-----------------------------------------------------------*/

Expand Down Expand Up @@ -212,7 +214,7 @@
}
/*-----------------------------------------------------------*/

static void prvCheckPendingReadyList( void )
STATIC void prvCheckPendingReadyList( void )
{
/* Are there any co-routines waiting to get moved to the ready list? These
* are co-routines that have been readied by an ISR. The ISR cannot access
Expand All @@ -235,7 +237,7 @@
}
/*-----------------------------------------------------------*/

static void prvCheckDelayedList( void )
STATIC void prvCheckDelayedList( void )
{
CRCB_t * pxCRCB;

Expand Down Expand Up @@ -333,7 +335,7 @@
}
/*-----------------------------------------------------------*/

static void prvInitialiseCoRoutineLists( void )
STATIC void prvInitialiseCoRoutineLists( void )
{
UBaseType_t uxPriority;

Expand Down
Loading