Fix POSIX redirection in Asterisk stop command - #246
Open
fabianbur wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use POSIX-compatible output redirection for the background Asterisk stop command in
Console/Stop.class.php.Why
Stop.class.phplaunches the Asterisk CLI throughshell_exec(). On Debian 12,/bin/shisdash, while&>is Bash-specific syntax.The current command uses:
asterisk -rx "core stop ..." &>/dev/null &Change it to the POSIX-compatible form:
asterisk -rx "core stop ..." >/dev/null 2>&1 &This avoids relying on Bash-specific redirection in a command executed through the system shell.
Validation
php -l amp_conf/htdocs/admin/libraries/Console/Stop.class.php— PASSgit diff --check— PASSScope
This PR fixes only the shell-redirection defect in
Stop.class.php.It does not claim to fix the separate DPMA
res_digium_phone.sounload hang described in the shutdown investigation.Related context:
FreePBX/issue-tracker#439