Skip to content

remove public prefix#1109

Merged
bryceknz merged 2 commits into
FormidableLabs:mainfrom
birkir:patch-1
May 18, 2026
Merged

remove public prefix#1109
bryceknz merged 2 commits into
FormidableLabs:mainfrom
birkir:patch-1

Conversation

@birkir
Copy link
Copy Markdown
Contributor

@birkir birkir commented Feb 18, 2026

Adds compatibility for Expo 55

Description

Expo does not use the public class prefix in version 55.

It should work with both new and old versions of Expo.

Fixes #1110

Expo does not use the public class prefix now. It should work with new and old versions of Expo.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 18, 2026

🦋 Changeset detected

Latest commit: 0b462f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-native-app-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 18, 2026

@birkir is attempting to deploy a commit to the formidable-labs Team on Vercel.

A member of the Team first needs to authorize it.

@smiLLe
Copy link
Copy Markdown

smiLLe commented Mar 10, 2026

#1110

any update on this?

@todesignandconquer
Copy link
Copy Markdown

Bump. Would be nice to get this fixed. Is this repo even maintained anymore?

@bryceknz
Copy link
Copy Markdown
Contributor

Hi @birkir,

Thank you for the fix. I verified that the updated class AppDelegate: ExpoAppDelegate match works for both the Expo 55 template and older public class AppDelegate: ExpoAppDelegate templates.

Validation performed:

  • Simulated the replacement against both old and new AppDelegate class declarations.
  • Sanity-checked the resulting Swift shape with the injected delegate property.
  • Ran yarn workspace react-native-app-auth build successfully.

One note: this likely needs a changeset if we want it included in the next package release.

Copy link
Copy Markdown
Contributor

@bryceknz bryceknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset added, ready for merge.

@bryceknz bryceknz merged commit 1f17e8b into FormidableLabs:main May 18, 2026
1 of 2 checks passed
@github-actions github-actions Bot mentioned this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expo 55 not working anymore

4 participants