-
Notifications
You must be signed in to change notification settings - Fork 0
feat(davinci): add SOCIAL_LOGIN_BUTTON IdP collector support (SDKS-5128) #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pingidentity-gaurav
wants to merge
3
commits into
main
Choose a base branch
from
SDKS-5128
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
00dde12
feat(davinci): add SOCIAL_LOGIN_BUTTON IdP collector support (SDKS-5128)
pingidentity-gaurav 06aec84
chore: merge main into SDKS-5128
pingidentity-gaurav 2e92fe8
test(davinci): fix Android IdpCollector test infrastructure (SDKS-5128)
pingidentity-gaurav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,3 +36,5 @@ junit.xml | |
| # Turborepo folder for persisting logs and outputs | ||
| .turbo | ||
| .sdk/ | ||
|
|
||
| .polaris/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: ForgeRock/ping-react-native-sdk
Length of output: 469
🌐 Web query:
Google Sign-In for iOS GIDServerClientID backend OAuth client ID developers.google.com💡 Result:
The GIDServerClientID key is used in your iOS or macOS application's Info.plist file to configure the Google Sign-In SDK for backend authentication or offline access [1][2][3]. When your application needs to communicate with a backend server—such as to verify the user's ID token or exchange an authorization code for tokens—it must identify your backend project to Google's authentication system [4][1]. The GIDServerClientID serves this purpose [1]. Key details regarding GIDServerClientID: 1. Purpose: It represents your backend server's OAuth client ID, not your iOS/macOS application's client ID [1]. Providing this allows the SDK to include the correct audience information in the ID token or to request an authorization code that your specific backend is authorized to exchange [5][4][6]. 2. Configuration: You set this by adding the GIDServerClientID key to your Info.plist file with your web application's OAuth client ID as the string value [1][3]: GIDServerClientID YOUR_SERVER_CLIENT_ID 3. Obtaining the ID: You must create this client ID in the Google Cloud Console by selecting the Web application type for your project's OAuth client ID [1]. If you do not include this key, you will be unable to securely authenticate users on your backend or perform offline access actions like obtaining a serverAuthCode [5][4][1]. For most integrations, this is an optional key used only if your app requires a backend component [1][3].
Citations:
Use the backend OAuth client ID for
GIDServerClientID.GIDServerClientIDmust be the web/server OAuth client ID used by the backend, whileGIDClientIDshould remain the iOS client ID.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents