chore: merge release/1.0.0-beta into main#45
Merged
Conversation
…kspace refs - Bump all packages to 1.0.0-beta.1 (patch) - Move @ping-identity/rn-core from dependencies → peerDependencies in all SDK packages so consumers must install it explicitly for autolinking - Remove @ping-identity/rn-storage from rn-push dependencies (optional dep) - Add scripts/replace-workspace-refs.mjs to rewrite workspace:* before publish - Add scripts/check-workspace-refs.mjs as a pre-publish safety check - Update release.yml to run both scripts before publishing - Update all package READMEs with rn-core prerequisite note Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rn-storage is needed in dependencies for TypeScript to resolve its types during build, and in peerDependencies so consumers know to install it for native autolinking. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Without codegenConfig, React Native autolinking does not register rn-core as a Gradle subproject, causing build failures in consumer apps that depend on :ping-identity_rn-core. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add RNPingCorePackage.kt so React Native autolinking registers rn-core as a Gradle subproject in consumer apps - Add rn-sample-app and rn-test-runner to changeset ignore list to prevent private packages from getting changelog/version bumps Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
More reviews will be available in 17 minutes and 12 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCoordinated 1.0.0-beta updates across the monorepo: pre-release changesets, core Android autolinking codegen and package, package.json version/dep rewrites, README/CHANGELOG updates, release workflow and workspace validation/replacement scripts, and demo app version bumps. ChangesSDK 1.0.0-beta Release
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
packages/device-profile/README.md (1)
53-57: ⚡ Quick winRemove duplicate CocoaPods installation instructions.
The installation block at lines 42-51 already includes the iOS
pod installstep at line 50. The separate section at lines 53-57 repeats the same instruction, which may confuse developers about whether they need to run the command once or twice.♻️ Proposed fix to remove duplication
- -If you use CocoaPods, install pods after adding the package: - -```sh -cd ios && pod install -``` -🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/device-profile/README.md` around lines 53 - 57, Remove the duplicated CocoaPods installation lines by deleting the second iOS pod install section (the snippet that says "If you use CocoaPods, install pods after adding the package: cd ios && pod install") so only the original installation block (the earlier installation block that already contains the "cd ios && pod install" step) remains; ensure no other content is changed and the README keeps a single clear instruction for running pod install.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/push/README.md`:
- Line 31: The README currently contradicts itself about
`@ping-identity/rn-storage`; decide and make the wording and install examples
consistent: if rn-storage is required, update the install block to include "yarn
add `@ping-identity/rn-storage`" alongside `@ping-identity/rn-core` and
`@ping-identity/rn-push` and remove `@ping-identity/rn-storage` from the "Optional
integration packages" list; if rn-storage is optional, edit the note line that
currently says both rn-core and rn-storage must be set up to only require
`@ping-identity/rn-core` and leave `@ping-identity/rn-storage` listed under optional
integrations (ensure package names `@ping-identity/rn-core`,
`@ping-identity/rn-storage`, and `@ping-identity/rn-push` are referenced correctly).
In `@PingSampleApp/CHANGELOG.md`:
- Around line 7-21: The CHANGELOGs for PingSampleApp and PingTestRunner show a
0.0.2-beta.1 patch despite .changeset/config.json claiming to ignore
rn-sample-app and rn-test-runner; check the changeset ignore configuration and
the actual package names used by changesets (compare the "name" fields in
PingSampleApp/package.json and PingTestRunner/package.json to the identifiers in
.changeset/config.json) and confirm the release workflow (e.g., the changesets
version or publish GitHub Action) is reading that config; if the names don’t
match, update .changeset/config.json to list the exact package names, or update
package.json names to match, then re-run the changesets version step (or adjust
the CI workflow) so ignored packages are not bumped and remove the unintended
0.0.2-beta.1 entries from PingSampleApp/CHANGELOG.md and
PingTestRunner/CHANGELOG.md if they were produced erroneously.
In `@scripts/check-workspace-refs.mjs`:
- Around line 31-33: The check currently only matches the exact string
'workspace:*' using ver === 'workspace:*' so variants like 'workspace:^' or
'workspace:~' slip through; change the condition in
scripts/check-workspace-refs.mjs to detect any workspace protocol by testing the
version string (e.g., use ver.startsWith('workspace:') or a regex like
/^workspace:/) before pushing into violations, so any 'workspace:...' spec
triggers the violation; keep using the same violations.push call and include the
actual ver in the message if desired.
In `@scripts/replace-workspace-refs.mjs`:
- Around line 45-53: The code currently only handles exact 'workspace:*' via the
ver variable; update the replacement logic to detect any value starting with
'workspace:' (e.g., ver.startsWith('workspace:')), extract the intended semantic
range (or default to '^') and, if versionMap[dep] exists, replace
pkg[section][dep] with the resolved range (e.g., `^${versionMap[dep]}` or
preserve an explicit workspace range if present); if versionMap[dep] is missing
for any workspace: reference, fail fast by throwing an Error or exiting with a
non‑zero code so unresolved workspace refs are not left in manifests. Ensure you
update the branch that currently checks ver === 'workspace:*' to use
ver.startsWith('workspace:') and reference ver, versionMap, pkg[section][dep],
dep and totalReplaced in the change.
---
Nitpick comments:
In `@packages/device-profile/README.md`:
- Around line 53-57: Remove the duplicated CocoaPods installation lines by
deleting the second iOS pod install section (the snippet that says "If you use
CocoaPods, install pods after adding the package: cd ios && pod install") so
only the original installation block (the earlier installation block that
already contains the "cd ios && pod install" step) remains; ensure no other
content is changed and the README keeps a single clear instruction for running
pod install.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 54ef60fa-3a0e-4269-a776-cb4818459be7
⛔ Files ignored due to path filters (2)
.yarn/install-state.gzis excluded by!**/.yarn/**,!**/*.gzyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (59)
.changeset/config.json.changeset/eighty-banks-feel.md.changeset/goofy-foxes-clap.md.changeset/hungry-papayas-learn.md.changeset/initial-beta-release.md.changeset/pre.json.github/workflows/release.ymlPingSampleApp/CHANGELOG.mdPingSampleApp/package.jsonPingTestRunner/CHANGELOG.mdPingTestRunner/package.jsonpackages/binding/CHANGELOG.mdpackages/binding/README.mdpackages/binding/package.jsonpackages/browser/CHANGELOG.mdpackages/browser/README.mdpackages/browser/package.jsonpackages/core/CHANGELOG.mdpackages/core/README.mdpackages/core/android/src/main/java/com/pingidentity/rncore/RNPingCorePackage.ktpackages/core/package.jsonpackages/device-client/CHANGELOG.mdpackages/device-client/README.mdpackages/device-client/package.jsonpackages/device-id/CHANGELOG.mdpackages/device-id/README.mdpackages/device-id/package.jsonpackages/device-profile/CHANGELOG.mdpackages/device-profile/README.mdpackages/device-profile/package.jsonpackages/external-idp/CHANGELOG.mdpackages/external-idp/README.mdpackages/external-idp/package.jsonpackages/fido/CHANGELOG.mdpackages/fido/README.mdpackages/fido/package.jsonpackages/journey/CHANGELOG.mdpackages/journey/README.mdpackages/journey/package.jsonpackages/logger/CHANGELOG.mdpackages/logger/README.mdpackages/logger/package.jsonpackages/oath/CHANGELOG.mdpackages/oath/README.mdpackages/oath/package.jsonpackages/oidc/CHANGELOG.mdpackages/oidc/README.mdpackages/oidc/package.jsonpackages/push/CHANGELOG.mdpackages/push/README.mdpackages/push/package.jsonpackages/storage/CHANGELOG.mdpackages/storage/README.mdpackages/storage/package.jsonpackages/types/CHANGELOG.mdpackages/types/package.jsonscripts/check-copyright.shscripts/check-workspace-refs.mjsscripts/replace-workspace-refs.mjs
- push README: move rn-storage to required install block, remove from optional - device-profile README: remove duplicate pod install section - check-workspace-refs: catch all workspace: variants not just workspace:* - replace-workspace-refs: catch all workspace: variants, fail fast on unresolved refs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.changeset/pre.jsonfromrelease/1.0.0-betaback tomain@ping-identity/rn-coretopeerDependenciesin all SDK packagesscripts/replace-workspace-refs.mjsto fixworkspace:*refs before publishRNPingCorePackage.ktfor Android autolinkingcodegenConfigtorn-corepackage.jsonrn-sample-app,rn-test-runner) from changesetTest plan
1.0.0-beta.3npm view @ping-identity/rn-core@betashows1.0.0-beta.3settings.gradleentrySummary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores