Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #170 +/- ##
=============================================
+ Coverage 44.92% 44.94% +0.02%
Complexity 1232 1232
=============================================
Files 302 302
Lines 9389 9389
Branches 1352 1352
=============================================
+ Hits 4218 4220 +2
Misses 4630 4630
+ Partials 541 539 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ryanbas21
approved these changes
Mar 16, 2026
spetrov
approved these changes
Mar 17, 2026
Contributor
spetrov
left a comment
spetrov
left a comment
There was a problem hiding this comment.
Approved, with some comments that we may want to consider before proceeding with this...
CONTRIBUTING.md
Outdated
| ```sh | ||
| git push origin your-feature-branch | ||
| ``` | ||
| 5. Open a **Pull Request** to the `main` branch of the original repository. |
Contributor
There was a problem hiding this comment.
Target branch should be develop, right?
george-bafaloukas-forgerock
approved these changes
Mar 17, 2026
george-bafaloukas-forgerock
left a comment
george-bafaloukas-forgerock
left a comment
There was a problem hiding this comment.
Echoing Stoyans comments
CONTRIBUTING.md
Outdated
| ```sh | ||
| git push origin your-feature-branch | ||
| ``` | ||
| 5. Open a **Pull Request** to the `main` branch of the original repository. |
CONTRIBUTING.md
Outdated
| 5. Open a **Pull Request** to the `main` branch of the original repository. | ||
| 6. In your Pull Request, please follow the template provided. This includes: | ||
| * **Linking to a JIRA ticket** if applicable. | ||
| * Providing a **clear description** of the changes you have made. |
There was a problem hiding this comment.
I would say clear description and justfication of the changes made
Key changes: - Created `CONTRIBUTING.md` to provide guidelines on project setup, testing, coding standards, and the pull request process. - Streamlined `README.md` by removing the experimental module list and adding a link to the official documentation. - Updated the license section in `README.md` to point to the project's MIT license file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
SDKS-4619
Description
Key changes:
CONTRIBUTING.mdto provide guidelines on project setup, testing, coding standards, and the pull request process.README.mdby removing the experimental module list and adding a link to the official documentation.README.mdto point to the project's MIT license file.