fix: prevent destructuring error when reading from stored values#584
Open
CEOehis wants to merge 1 commit intoForgeRock:developfrom
Open
fix: prevent destructuring error when reading from stored values#584CEOehis wants to merge 1 commit intoForgeRock:developfrom
CEOehis wants to merge 1 commit intoForgeRock:developfrom
Conversation
…lues `getStoredAuthUrlValues` can sometimes return null (e.g when the item is not found in storage) and attempting to destructure the return value causes an uncaught runtime error. Changes: - default to empty object with nullish coallescing before destructuring - update `getStoredAuthUrlValues` type definition to reflect actual return type This ensures the proper error handling downstream, where `state` and `verifier` are checked for undefined values, works as intended rather than crashing on destructuring.
|
Contributor
|
@CEOehis thanks, the team will look to review this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getStoredAuthUrlValuescan sometimes return null (e.g when the item is not found in storage) and attempting to destructure the return value causes an uncaught runtime error.Changes:
getStoredAuthUrlValuestype definition to reflect actual return typeThis ensures the proper error handling downstream, where
stateandverifierare checked for undefined values, works as intended rather than crashing on destructuring.