Skip to content

fixed custom block ui #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RETR0-OS merged 5 commits into from
Feb 14, 2026
Merged

fixed custom block ui #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
24eb234
fixed naming error for batch norm block
devgunnu Feb 8, 2026
5fc8c83
removed the background square
devgunnu Feb 9, 2026
e341440
fixed custom block ui
devgunnu Feb 9, 2026
30009a4
Fix indentation in validation checks for node types
RETR0-OS Feb 14, 2026
d834f29
Fix validation check for node types
RETR0-OS Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions project/block_manager/services/nodes/pytorch/batchnorm2d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ class BatchNorm2DNode(NodeDefinition):
@property
def metadata(self) -> NodeMetadata:
return NodeMetadata(
type="batchnorm2d",
label="BatchNorm2D",
type="batchnorm",
label="Batch Normalization",
Comment on lines +13 to +14
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node type is being changed from "batchnorm2d" to "batchnorm", but the validation logic in validation.py line 327 still includes both "batchnorm" and "batchnorm2d" in the required input check. Since the type is now "batchnorm", the reference to "batchnorm2d" in that list should be removed to avoid confusion. While this change doesn't break functionality (since "batchnorm" is already in the list), it creates technical debt by keeping a reference to a type that no longer exists.

Copilot uses AI. Check for mistakes.
category="basic",
color="var(--color-primary)",
color="var(--color-accent)",
icon="ChartLineUp",
description="Batch normalization for 2D inputs",
description="Batch normalization layer",
framework=Framework.PYTORCH
)

Expand Down
8 changes: 4 additions & 4 deletions project/block_manager/services/nodes/tensorflow/batchnorm2d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ class BatchNorm2DNode(NodeDefinition):
@property
def metadata(self) -> NodeMetadata:
return NodeMetadata(
type="batchnorm2d",
label="BatchNorm2D",
type="batchnorm",
label="Batch Normalization",
Comment on lines +13 to +14
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node type is being changed from "batchnorm2d" to "batchnorm", but the validation logic in validation.py line 327 still includes both "batchnorm" and "batchnorm2d" in the required input check. Since the type is now "batchnorm", the reference to "batchnorm2d" in that list should be removed to avoid confusion. While this change doesn't break functionality (since "batchnorm" is already in the list), it creates technical debt by keeping a reference to a type that no longer exists.

Copilot uses AI. Check for mistakes.
category="basic",
color="var(--color-orange)",
icon="Zap",
color="var(--color-accent)",
icon="ChartLineUp",
description="Batch normalization layer",
framework=Framework.TENSORFLOW
)
Expand Down
2 changes: 1 addition & 1 deletion project/block_manager/services/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ def _validate_shape_compatibility(self):
incoming = edge_map.get(node_id, [])

# Check that nodes with required inputs have connections
if node_type in ('conv2d', 'linear', 'maxpool2d', 'maxpool', 'batchnorm', 'batchnorm2d', 'flatten'):
if node_type in ('conv2d', 'linear', 'maxpool2d', 'maxpool', 'batchnorm', 'flatten'):
if not incoming:
self.errors.append(ValidationError(
message=f'{node_type} layer requires an input connection',
Expand Down
53 changes: 29 additions & 24 deletions project/frontend/src/components/GroupBlockNode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,10 @@ const GroupBlockNode = memo(({ data, selected, id }: GroupBlockNodeProps) => {

{/* Render input handles */}
{inputPorts.map((port, index) => {
const spacing = 100 / (inputPorts.length + 1)
const topPercent = spacing * (index + 1)
const rangeStart = 70
const rangeEnd = 90
const spacing = (rangeEnd - rangeStart) / (inputPorts.length + 1)
const topPercent = rangeStart + spacing * (index + 1)
const color = getPortColor(port.semantic)
const isConnected = isHandleConnected(port.externalPortId, true)

Expand Down Expand Up @@ -212,45 +214,46 @@ const GroupBlockNode = memo(({ data, selected, id }: GroupBlockNodeProps) => {
)
})}

<div className="p-3 space-y-2">
<div className="p-3">
<div className="flex items-center gap-2">
<div
className="p-1.5 rounded"
className="p-1 rounded shrink-0"
style={{
backgroundColor: groupDef.color,
color: 'white'
}}
>
<Icons.SquaresFour size={16} weight="bold" />
<Icons.SquaresFour size={14} weight="bold" />
</div>
<div className="flex-1 min-w-0">
<div className="font-semibold text-sm truncate">
<div className="font-semibold text-sm truncate leading-tight">
{groupDef.name}
</div>
<div className="flex items-center gap-1">
<Badge
variant="secondary"
className="text-[9px] px-1 py-0 h-3.5"
>
{groupDef.category}
</Badge>
<Badge
variant="outline"
className="text-[9px] px-1 py-0 h-3.5"
>
{groupDef.internalNodes.length} nodes
</Badge>
</div>
</div>
</div>

<div className="flex items-center gap-1 mt-1">
<Badge
variant="secondary"
className="text-[9px] px-1 py-0 h-3.5"
>
{groupDef.category}
</Badge>
<Badge
variant="outline"
className="text-[9px] px-1 py-0 h-3.5"
>
{groupDef.internalNodes.length} nodes
</Badge>
</div>

{groupDef.description && (
<div className="text-[10px] text-muted-foreground line-clamp-2">
<div className="text-[10px] text-muted-foreground line-clamp-2 mt-1">
{groupDef.description}
</div>
)}

<div className="flex items-center gap-1 text-[10px] text-muted-foreground">
<div className="flex items-center gap-1 text-[10px] text-muted-foreground mt-1">
<Icons.ArrowsIn size={12} />
<span>{inputPorts.length} in</span>
<span className="mx-1">•</span>
Expand All @@ -261,8 +264,10 @@ const GroupBlockNode = memo(({ data, selected, id }: GroupBlockNodeProps) => {

{/* Render output handles */}
{outputPorts.map((port, index) => {
const spacing = 100 / (outputPorts.length + 1)
const topPercent = spacing * (index + 1)
const rangeStart = 70
const rangeEnd = 90
const spacing = (rangeEnd - rangeStart) / (outputPorts.length + 1)
const topPercent = rangeStart + spacing * (index + 1)
const color = getPortColor(port.semantic)
const isConnected = isHandleConnected(port.externalPortId, false)

Expand Down
7 changes: 7 additions & 0 deletions project/frontend/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,13 @@ body {
font-family: var(--font-sans);
}

.react-flow__node-group {
background: transparent !important;
border: none !important;
padding: 0 !important;
box-shadow: none !important;
}

code, pre {
font-family: var(--font-mono);
}