chore(agent): bump rack-cors to ~> 3.0#315
Merged
Merged
Conversation
rack-cors 3.0.0 only raises its floor to Rack >= 3.0.14, drops Ruby 2.3, and adds an explicit logger dependency. All are already satisfied (Rack 3.2.6 resolved, Ruby >= 3.0 required, logger present). The CORS config DSL used in the rails engine is unchanged, and the CORS specs pass on 3.0.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
✅ Verified against the forest POCTested the bump end-to-end with the local POC (
App boot: Full Rails environment loads with rack-cors 3.0.0 on rack 3.2.6 — Live CORS behavior — exercised the engine's exact
The origin regex Conclusion: the |
matthv
approved these changes
Jun 9, 2026
Member
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the
rack-corsruntime dependency offorest_admin_agentfrom~> 2.0(resolved 2.0.2) to~> 3.0(resolved 3.0.0).Why it's safe
rack-cors 3.0.0 is the only release after 2.0.2, and its breaking changes are purely environmental — no config DSL changes:
>= 3.0.14>= 3.0.0loggerruntime depThe CORS config DSL (
allow/origins/resource) used inforest_admin_rails/lib/forest_admin_rails/engine.rbis unchanged in 3.0.0.Testing
engine_spec.rb) — passforest_controller_spec.rb"exposes Content-Disposition via CORS" — passroutes_specAgentFactorystubbing) reproduce identically on rack-cors 2.0.2 / pass in isolation, so they are pre-existing test-isolation issues unrelated to this change.Note: package
Gemfile.lockfiles are gitignored, so only the gemspec constraint is committed.Note
Bump
rack-corsdependency to~> 3.0in forest_admin_agentUpdates the
rack-corsconstraint in forest_admin_agent.gemspec from~> 2.0to~> 3.0. Risk: projects depending on this gem must now haverack-cors3.x available.Macroscope summarized 48fae14.