Skip to content

fix: normalize default values in schema for ruby 4.0 and rails 8 compatibility #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matthv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: normalize default values in schema for ruby 4.0 and rails 8 compatibility #252

matthv wants to merge 1 commit into from

Conversation

@matthv
Copy link
Member

@matthv matthv commented Jan 16, 2026

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Jan 16, 2026

1 new issue

Tool Category Rule Count
qlty Structure Function with high complexity (count = 5): normalize_default_value 1

qltysh[bot]
qltysh bot reviewed Jan 16, 2026
View reviewed changes
...st_admin_datasource_active_record/lib/forest_admin_datasource_active_record/parser/column.rb
column.default.to_f
else
column.default
end
Copy link

@qltysh qltysh bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 5): normalize_default_value [qlty:function-complexity]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qltysh qltysh[bot] qltysh[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthv