Fix Docker mount warning to respect *_DIR env vars#391
Open
joaquinhuigomez wants to merge 1 commit intoForceu:masterfrom
Open
Fix Docker mount warning to respect *_DIR env vars#391joaquinhuigomez wants to merge 1 commit intoForceu:masterfrom
joaquinhuigomez wants to merge 1 commit intoForceu:masterfrom
Conversation
Use GOKAPI_CONFIG_DIR and GOKAPI_DATA_DIR to determine the actual directories to check for volume mounts instead of hardcoded /app/config and /app/data. Also walk parent directories when checking mounts so that a single volume mounted at a parent path (e.g. /mnt_vol) is correctly detected for subdirectories (e.g. /mnt_vol/data). Fixes Forceu#387
Owner
|
Thank you for the PR. Has the code been tested and has there been any AI involved in creating this code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker missing-mount warning always checks the hardcoded paths /app/data and /app/config. When GOKAPI_CONFIG_DIR or GOKAPI_DATA_DIR point to custom locations, the warning fires even though the actual directories are properly mounted.
This reads the resolved environment directories and walks parent paths when checking /proc/mounts, so a single volume mounted at a parent (e.g. /mnt_vol) is correctly detected for subdirectories like /mnt_vol/data.
Fixes #387